From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CB31B1B245
 for <dev@dpdk.org>; Mon,  2 Oct 2017 16:55:51 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 5952F215B2;
 Mon,  2 Oct 2017 10:55:51 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Mon, 02 Oct 2017 10:55:51 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=eXd+1qAz0LGJeSM
 qclQiGxXfya92emJS/v1MX/UVO3M=; b=JtAbWThjGS3wX/tJwHnI2K0o+6Qz8QF
 /SP7LrG68Bfwe+KWShttJpxzcetiuvPPdGJQAQdKkrXrmskKWbvzazQ1tKXVPmcF
 V8IQMVBhNYCyOHZ/9Qa5dFILA1w+YKklTwxx/Yk8wJS88vX43H0Ysh2Vaam9pb3t
 OionDbJKD3/8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=eXd+1qAz0LGJeSMqclQiGxXfya92emJS/v1MX/UVO3M=; b=oimMsPEG
 /E1x2jqImD81fMtfA0t/Lfc+mN2IRXAGTJiub94NLDyIeA/hsoGkKcVUnQ1bLKd9
 g51n1kSR0FWi4gsqs3OHXln1SjbVUbkhg7cxLt3ZkSM/Rw6pdrX7Mh73ioCBdbll
 pSbLFu1eLGkYKwrWw59KFVM8u+MKapf9W87B4IhlBZ70kEUou2XN1CjPgOhopXTv
 ElP74ilGVJDE1OK89n2uFA2R3NatHu4xe9ly+LrfmKkdxY/ts/PeBlduZMhAo4fy
 cGZd3NjOVqOriKzFZqYjXX5xjTvYLiCYlfkAjNQyBRDdTFv440fEL5mSW3gmRc72
 91uE6XWUGUCg0g==
X-ME-Sender: <xms:d1PSWY5yOb0BGHnMxpbt7r1e2dCaSypu5CCVDqE-3ue6_kYwCyZbXw>
X-Sasl-enc: FnQ/G/JzIKw03l7MyP/vA9K53+q1661SjNRu76ANdQZu 1506956151
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 054C97FA60;
 Mon,  2 Oct 2017 10:55:51 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org
Date: Mon, 02 Oct 2017 16:55:49 +0200
Message-ID: <1556159.HUIlaTtd6f@xps>
In-Reply-To: <1506946848-173847-1-git-send-email-david.hunt@intel.com>
References: <1506946848-173847-1-git-send-email-david.hunt@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Oct 2017 14:55:52 -0000

Hi,
I have some comments about the API scope and some formatting.

Suggested title:
	power: add turbo functions to map file

02/10/2017 14:20, David Hunt:
> allows vm_power_manager example to be built against shared libraries

Fixes: 94608a0f7f45 ("power: add per-core turbo boost API")

> Signed-off-by: David Hunt <david.hunt@intel.com>
[...]
> +DPDK_17.11 {
> +	global:
> +
> +	rte_power_acpi_turbo_status;

Is it really the function you want to expose?
rte_power_turbo_status seems more generic.

More comments about what is part of the API:
If you do not want to expose ACPI and VM implementations,
it should not be part of the rte_* include files.

> +	rte_power_freq_disable_turbo;
> +	rte_power_freq_enable_turbo;
> +};
> +

This is a trailing new line.