From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D004B3195 for ; Thu, 19 Jul 2018 14:09:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 50F3A21B81; Thu, 19 Jul 2018 08:09:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 19 Jul 2018 08:09:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=pIICo06eVjcIxYwhkQym5Xh99u PEc234f2jiEl9sKLo=; b=XBd+ZxZhKBA2m0KArVyb2LDIMnLTtmdXVvSvzpCB5e XkA5ZfIyRDOADBezk2ESjpiTDoYzmpbDxjwD7sGOxW0m+iR34E8FWyKBsFNF83n2 WUFw6xVZVA2nyTKla5YyKhBr1Swes+ORL6bWaQr5D9IBbVFWPuoWQLxF9CvDxbQ/ U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=pIICo0 6eVjcIxYwhkQym5Xh99uPEc234f2jiEl9sKLo=; b=SQFGCA+ifxocLBBkjvgh+B bin8JSstYpZ33+4Ioo9QCrQ88bWxrpFNs1uZ1AGQnnml1gMB5EiYgMWwYuj1tc0S 3q9bVuVIcjFD0I/1XgqnVJYpezRj+xnTVbEWOB/rQ+h4gtqsGAt0fOPEFEFwlufh YZW7bg0bOfBYVu/LA4PdibJpgDix57s41OFxQccPyEVJ+mqPN318bgBSPJJ9ltes L21fknGWFP0Byvb8axlD2qquSZljTANOqyhm9E5MqqnHhr4SH+WSXHp4ii5967bN mOjuCmJAnnjNc/X5iN5X5ynBSHwzhRe0Yifc+vCeoW01q8KVYXypJD1AH5KstlhQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 2EC4E10269; Thu, 19 Jul 2018 08:09:50 -0400 (EDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org Date: Thu, 19 Jul 2018 14:09:47 +0200 Message-ID: <1556161.F30VP9S7cZ@xps> In-Reply-To: <20180719111427.GA20362@hmswarspite.think-freely.org> References: <20180718210609.32547-1-thomas@monjalon.net> <20180718212658.24756-1-thomas@monjalon.net> <20180719111427.GA20362@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] devtools: fix symbol check for filename with space X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 12:09:52 -0000 19/07/2018 13:14, Neil Horman: > On Wed, Jul 18, 2018 at 11:26:58PM +0200, Thomas Monjalon wrote: > > If the patch filename or the temporary file path have a space > > in their name, the script check-symbol-change.sh does not work. > > The variables for the filenames must be enclosed in quotes > > in order to preserve spaces. > > > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > Cc: nhorman@tuxdriver.com > > > > Signed-off-by: Thomas Monjalon > > --- > > v2: one occurence of "$mapfile" was missed in v1 > I don't have any issue with this change, but the only way I see to introduce a > space into the tempfile name is to set $TMPDIR to '/path/with silly spaces' or > something simmilar. I think we discussed this before, but it would alsmot make > sense to, instead of quoting everything, instead specify -p ./ to ensure the > tempfile has no spaces. When I save patches from my inbox, the filename has some spaces. I think quoting variables is mandatory.