From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Cyril Chemparathy <cchemparathy@tilera.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/6] Extensions to test-pmd
Date: Mon, 19 May 2014 11:31:34 +0200 [thread overview]
Message-ID: <15561928.x5QfvWktoO@xps13> (raw)
In-Reply-To: <5376430A.8010707@tilera.com>
2014-05-16 09:55, Cyril Chemparathy:
> On 5/16/2014 7:22 AM, Thomas Monjalon wrote:
> > This is not the first time a new engine is added by copy/pasting the most
> > part of an existing engine. For instance, the "mac-retry" engine was
> > added by Intel as a copy/paste of the original "mac" one.
> > This is acceptable but not the perfect way to implement engines.
> > To address this issue, a new engine function could be introduced to setup
> > some parameters to be used by "packet_fwd" function. This way, similar
> > engines could be removed.
>
> Agreed that it sucks to incessantly replicate code. Maybe some of the
> packet_fwd code is common enough to bump into run_pkt_fwd_on_lcore()?
> Most of these forwarding modes have similar looking code to
> receive/transmit bursts and free the failed remnants of the burst.
> Could this common code be bumped up into run_pkt_fwd_on_lcore() maybe?
Not sure it fits into run_pkt_fwd_on_lcore() for all engines.
Feel free to suggest patches :)
--
Thomas
prev parent reply other threads:[~2014-05-19 9:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 17:30 Cyril Chemparathy
2014-04-03 17:30 ` [dpdk-dev] [PATCH 1/6] test-pmd: add support for single port loopback topology Cyril Chemparathy
2014-04-03 17:30 ` [dpdk-dev] [PATCH 2/6] test-pmd: add support for auto-start when interactive Cyril Chemparathy
2014-04-03 17:30 ` [dpdk-dev] [PATCH 3/6] test-pmd: allow command line selection of forwarding mode Cyril Chemparathy
2014-04-04 8:21 ` Richardson, Bruce
2014-05-14 17:05 ` [dpdk-dev] [PATCH] app/testpmd: list forwarding modes Thomas Monjalon
2014-05-15 9:35 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2014-05-15 16:08 ` [dpdk-dev] [PATCH v3] app/testpmd: list forwarding engines Thomas Monjalon
2014-05-16 7:21 ` Ivan Boule
2014-05-16 14:24 ` Thomas Monjalon
2014-04-03 17:30 ` [dpdk-dev] [PATCH 4/6] test-pmd: allow txpkts to be setup via command line Cyril Chemparathy
2014-04-03 17:30 ` [dpdk-dev] [PATCH 5/6] test-pmd: add mac swap forwarding mode Cyril Chemparathy
2014-04-03 17:30 ` [dpdk-dev] [PATCH 6/6] test-pmd: add flowgen forwarding engine Cyril Chemparathy
2014-05-16 14:22 ` [dpdk-dev] [PATCH 0/6] Extensions to test-pmd Thomas Monjalon
2014-05-16 16:55 ` Cyril Chemparathy
2014-05-19 9:31 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15561928.x5QfvWktoO@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=cchemparathy@tilera.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).