* [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols
2019-05-03 14:34 [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols David Marchand
@ 2019-05-03 14:34 ` David Marchand
2019-05-03 14:34 ` [dpdk-dev] [PATCH 2/4] devtools: handle section suppression David Marchand
` (3 subsequent siblings)
4 siblings, 0 replies; 22+ messages in thread
From: David Marchand @ 2019-05-03 14:34 UTC (permalink / raw)
To: dev; +Cc: thomas, nhorman
No need to shout when we are just reordering symbols in a section.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/check-symbol-change.sh | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 40eb953..8da7650 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -121,6 +121,12 @@ check_for_rule_violations()
continue
fi
+ # This symbol is moving inside a section, nothing to do
+ if [ "$oldsecname" = "$secname" ]
+ then
+ continue
+ fi
+
# This symbol is moving between two sections (the
# original section is not experimental).
# This can be legit, just warn.
--
1.8.3.1
^ permalink raw reply [flat|nested] 22+ messages in thread* [dpdk-dev] [PATCH 2/4] devtools: handle section suppression
2019-05-03 14:34 [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols David Marchand
2019-05-03 14:34 ` David Marchand
@ 2019-05-03 14:34 ` David Marchand
2019-05-03 14:34 ` David Marchand
2019-05-03 15:03 ` Neil Horman
2019-05-03 14:34 ` [dpdk-dev] [PATCH 3/4] devtools: fix symbol name in log message David Marchand
` (2 subsequent siblings)
4 siblings, 2 replies; 22+ messages in thread
From: David Marchand @ 2019-05-03 14:34 UTC (permalink / raw)
To: dev; +Cc: thomas, nhorman, stable
Even if rare, the check script should handle removing a section.
Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/check-symbol-change.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 8da7650..d5fad04 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -32,6 +32,7 @@ build_map_changes()
# symbol rule below
/^.*{/ {
gsub("+", "");
+ gsub("-", "");
if (in_map == 1) {
sec=$(NF-1); in_sec=1;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 22+ messages in thread* [dpdk-dev] [PATCH 2/4] devtools: handle section suppression
2019-05-03 14:34 ` [dpdk-dev] [PATCH 2/4] devtools: handle section suppression David Marchand
@ 2019-05-03 14:34 ` David Marchand
2019-05-03 15:03 ` Neil Horman
1 sibling, 0 replies; 22+ messages in thread
From: David Marchand @ 2019-05-03 14:34 UTC (permalink / raw)
To: dev; +Cc: thomas, nhorman, stable
Even if rare, the check script should handle removing a section.
Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/check-symbol-change.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 8da7650..d5fad04 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -32,6 +32,7 @@ build_map_changes()
# symbol rule below
/^.*{/ {
gsub("+", "");
+ gsub("-", "");
if (in_map == 1) {
sec=$(NF-1); in_sec=1;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression
2019-05-03 14:34 ` [dpdk-dev] [PATCH 2/4] devtools: handle section suppression David Marchand
2019-05-03 14:34 ` David Marchand
@ 2019-05-03 15:03 ` Neil Horman
2019-05-03 15:03 ` Neil Horman
2019-05-03 17:16 ` David Marchand
1 sibling, 2 replies; 22+ messages in thread
From: Neil Horman @ 2019-05-03 15:03 UTC (permalink / raw)
To: David Marchand; +Cc: dev, thomas, stable
On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote:
> Even if rare, the check script should handle removing a section.
>
> Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> devtools/check-symbol-change.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index 8da7650..d5fad04 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -32,6 +32,7 @@ build_map_changes()
> # symbol rule below
> /^.*{/ {
> gsub("+", "");
> + gsub("-", "");
> if (in_map == 1) {
> sec=$(NF-1); in_sec=1;
> }
> --
> 1.8.3.1
>
>
Don't you also need to add some logic in the symbol detection match rule to
print an appropriate indicator that a symbol is being removed? With just this
change, you will note that you are parsing a section, but you will never trigger
a symbol match
Neil
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression
2019-05-03 15:03 ` Neil Horman
@ 2019-05-03 15:03 ` Neil Horman
2019-05-03 17:16 ` David Marchand
1 sibling, 0 replies; 22+ messages in thread
From: Neil Horman @ 2019-05-03 15:03 UTC (permalink / raw)
To: David Marchand; +Cc: dev, thomas, stable
On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote:
> Even if rare, the check script should handle removing a section.
>
> Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> devtools/check-symbol-change.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index 8da7650..d5fad04 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -32,6 +32,7 @@ build_map_changes()
> # symbol rule below
> /^.*{/ {
> gsub("+", "");
> + gsub("-", "");
> if (in_map == 1) {
> sec=$(NF-1); in_sec=1;
> }
> --
> 1.8.3.1
>
>
Don't you also need to add some logic in the symbol detection match rule to
print an appropriate indicator that a symbol is being removed? With just this
change, you will note that you are parsing a section, but you will never trigger
a symbol match
Neil
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression
2019-05-03 15:03 ` Neil Horman
2019-05-03 15:03 ` Neil Horman
@ 2019-05-03 17:16 ` David Marchand
2019-05-03 17:16 ` David Marchand
2019-05-06 12:56 ` David Marchand
1 sibling, 2 replies; 22+ messages in thread
From: David Marchand @ 2019-05-03 17:16 UTC (permalink / raw)
To: Neil Horman; +Cc: dev, Thomas Monjalon, dpdk stable
On Fri, May 3, 2019 at 5:18 PM Neil Horman <nhorman@tuxdriver.com> wrote:
> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote:
> > Even if rare, the check script should handle removing a section.
> >
> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > devtools/check-symbol-change.sh | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/devtools/check-symbol-change.sh
> b/devtools/check-symbol-change.sh
> > index 8da7650..d5fad04 100755
> > --- a/devtools/check-symbol-change.sh
> > +++ b/devtools/check-symbol-change.sh
> > @@ -32,6 +32,7 @@ build_map_changes()
> > # symbol rule below
> > /^.*{/ {
> > gsub("+", "");
> > + gsub("-", "");
> > if (in_map == 1) {
> > sec=$(NF-1); in_sec=1;
> > }
> > --
> > 1.8.3.1
> >
> >
> Don't you also need to add some logic in the symbol detection match rule to
> print an appropriate indicator that a symbol is being removed? With just
> this
> change, you will note that you are parsing a section, but you will never
> trigger
> a symbol match
>
I do remember seeing a warning about the "-EXPERIMENTAL" section.
And this is why I added this.
But since then I reorganised my series and eliminated some parts... so you
are most likely right.
I will double check and repost.
--
David Marchand
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression
2019-05-03 17:16 ` David Marchand
@ 2019-05-03 17:16 ` David Marchand
2019-05-06 12:56 ` David Marchand
1 sibling, 0 replies; 22+ messages in thread
From: David Marchand @ 2019-05-03 17:16 UTC (permalink / raw)
To: Neil Horman; +Cc: dev, Thomas Monjalon, dpdk stable
On Fri, May 3, 2019 at 5:18 PM Neil Horman <nhorman@tuxdriver.com> wrote:
> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote:
> > Even if rare, the check script should handle removing a section.
> >
> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > devtools/check-symbol-change.sh | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/devtools/check-symbol-change.sh
> b/devtools/check-symbol-change.sh
> > index 8da7650..d5fad04 100755
> > --- a/devtools/check-symbol-change.sh
> > +++ b/devtools/check-symbol-change.sh
> > @@ -32,6 +32,7 @@ build_map_changes()
> > # symbol rule below
> > /^.*{/ {
> > gsub("+", "");
> > + gsub("-", "");
> > if (in_map == 1) {
> > sec=$(NF-1); in_sec=1;
> > }
> > --
> > 1.8.3.1
> >
> >
> Don't you also need to add some logic in the symbol detection match rule to
> print an appropriate indicator that a symbol is being removed? With just
> this
> change, you will note that you are parsing a section, but you will never
> trigger
> a symbol match
>
I do remember seeing a warning about the "-EXPERIMENTAL" section.
And this is why I added this.
But since then I reorganised my series and eliminated some parts... so you
are most likely right.
I will double check and repost.
--
David Marchand
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression
2019-05-03 17:16 ` David Marchand
2019-05-03 17:16 ` David Marchand
@ 2019-05-06 12:56 ` David Marchand
2019-05-06 12:56 ` David Marchand
2019-05-06 15:43 ` Neil Horman
1 sibling, 2 replies; 22+ messages in thread
From: David Marchand @ 2019-05-06 12:56 UTC (permalink / raw)
To: Neil Horman; +Cc: dev, Thomas Monjalon, dpdk stable
On Fri, May 3, 2019 at 7:16 PM David Marchand <david.marchand@redhat.com>
wrote:
> On Fri, May 3, 2019 at 5:18 PM Neil Horman <nhorman@tuxdriver.com> wrote:
>
>> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote:
>> > Even if rare, the check script should handle removing a section.
>> >
>> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
>> > Cc: stable@dpdk.org
>> >
>> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>> > ---
>> > devtools/check-symbol-change.sh | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/devtools/check-symbol-change.sh
>> b/devtools/check-symbol-change.sh
>> > index 8da7650..d5fad04 100755
>> > --- a/devtools/check-symbol-change.sh
>> > +++ b/devtools/check-symbol-change.sh
>> > @@ -32,6 +32,7 @@ build_map_changes()
>> > # symbol rule below
>> > /^.*{/ {
>> > gsub("+", "");
>> > + gsub("-", "");
>> > if (in_map == 1) {
>> > sec=$(NF-1); in_sec=1;
>> > }
>> > --
>> > 1.8.3.1
>> >
>> >
>> Don't you also need to add some logic in the symbol detection match rule
>> to
>> print an appropriate indicator that a symbol is being removed? With just
>> this
>> change, you will note that you are parsing a section, but you will never
>> trigger
>> a symbol match
>>
>
> I do remember seeing a warning about the "-EXPERIMENTAL" section.
> And this is why I added this.
> But since then I reorganised my series and eliminated some parts... so you
> are most likely right.
> I will double check and repost.
>
>
Yes, you are right, I moved this out of another patch that I ended up not
sending.
But it makes no sense by itself.
I will drop this in v2.
Any comments on the other patches ?
Thanks Neil.
--
David Marchand
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression
2019-05-06 12:56 ` David Marchand
@ 2019-05-06 12:56 ` David Marchand
2019-05-06 15:43 ` Neil Horman
1 sibling, 0 replies; 22+ messages in thread
From: David Marchand @ 2019-05-06 12:56 UTC (permalink / raw)
To: Neil Horman; +Cc: dev, Thomas Monjalon, dpdk stable
On Fri, May 3, 2019 at 7:16 PM David Marchand <david.marchand@redhat.com>
wrote:
> On Fri, May 3, 2019 at 5:18 PM Neil Horman <nhorman@tuxdriver.com> wrote:
>
>> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote:
>> > Even if rare, the check script should handle removing a section.
>> >
>> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
>> > Cc: stable@dpdk.org
>> >
>> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>> > ---
>> > devtools/check-symbol-change.sh | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/devtools/check-symbol-change.sh
>> b/devtools/check-symbol-change.sh
>> > index 8da7650..d5fad04 100755
>> > --- a/devtools/check-symbol-change.sh
>> > +++ b/devtools/check-symbol-change.sh
>> > @@ -32,6 +32,7 @@ build_map_changes()
>> > # symbol rule below
>> > /^.*{/ {
>> > gsub("+", "");
>> > + gsub("-", "");
>> > if (in_map == 1) {
>> > sec=$(NF-1); in_sec=1;
>> > }
>> > --
>> > 1.8.3.1
>> >
>> >
>> Don't you also need to add some logic in the symbol detection match rule
>> to
>> print an appropriate indicator that a symbol is being removed? With just
>> this
>> change, you will note that you are parsing a section, but you will never
>> trigger
>> a symbol match
>>
>
> I do remember seeing a warning about the "-EXPERIMENTAL" section.
> And this is why I added this.
> But since then I reorganised my series and eliminated some parts... so you
> are most likely right.
> I will double check and repost.
>
>
Yes, you are right, I moved this out of another patch that I ended up not
sending.
But it makes no sense by itself.
I will drop this in v2.
Any comments on the other patches ?
Thanks Neil.
--
David Marchand
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression
2019-05-06 12:56 ` David Marchand
2019-05-06 12:56 ` David Marchand
@ 2019-05-06 15:43 ` Neil Horman
2019-05-06 15:43 ` Neil Horman
1 sibling, 1 reply; 22+ messages in thread
From: Neil Horman @ 2019-05-06 15:43 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Thomas Monjalon, dpdk stable
On Mon, May 06, 2019 at 02:56:51PM +0200, David Marchand wrote:
> On Fri, May 3, 2019 at 7:16 PM David Marchand <david.marchand@redhat.com>
> wrote:
>
> > On Fri, May 3, 2019 at 5:18 PM Neil Horman <nhorman@tuxdriver.com> wrote:
> >
> >> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote:
> >> > Even if rare, the check script should handle removing a section.
> >> >
> >> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> >> > Cc: stable@dpdk.org
> >> >
> >> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> >> > ---
> >> > devtools/check-symbol-change.sh | 1 +
> >> > 1 file changed, 1 insertion(+)
> >> >
> >> > diff --git a/devtools/check-symbol-change.sh
> >> b/devtools/check-symbol-change.sh
> >> > index 8da7650..d5fad04 100755
> >> > --- a/devtools/check-symbol-change.sh
> >> > +++ b/devtools/check-symbol-change.sh
> >> > @@ -32,6 +32,7 @@ build_map_changes()
> >> > # symbol rule below
> >> > /^.*{/ {
> >> > gsub("+", "");
> >> > + gsub("-", "");
> >> > if (in_map == 1) {
> >> > sec=$(NF-1); in_sec=1;
> >> > }
> >> > --
> >> > 1.8.3.1
> >> >
> >> >
> >> Don't you also need to add some logic in the symbol detection match rule
> >> to
> >> print an appropriate indicator that a symbol is being removed? With just
> >> this
> >> change, you will note that you are parsing a section, but you will never
> >> trigger
> >> a symbol match
> >>
> >
> > I do remember seeing a warning about the "-EXPERIMENTAL" section.
> > And this is why I added this.
> > But since then I reorganised my series and eliminated some parts... so you
> > are most likely right.
> > I will double check and repost.
> >
> >
> Yes, you are right, I moved this out of another patch that I ended up not
> sending.
> But it makes no sense by itself.
> I will drop this in v2.
>
> Any comments on the other patches ?
> Thanks Neil.
>
No, I don't think I do, thanks for checking though!
Neil
>
> --
> David Marchand
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression
2019-05-06 15:43 ` Neil Horman
@ 2019-05-06 15:43 ` Neil Horman
0 siblings, 0 replies; 22+ messages in thread
From: Neil Horman @ 2019-05-06 15:43 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Thomas Monjalon, dpdk stable
On Mon, May 06, 2019 at 02:56:51PM +0200, David Marchand wrote:
> On Fri, May 3, 2019 at 7:16 PM David Marchand <david.marchand@redhat.com>
> wrote:
>
> > On Fri, May 3, 2019 at 5:18 PM Neil Horman <nhorman@tuxdriver.com> wrote:
> >
> >> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote:
> >> > Even if rare, the check script should handle removing a section.
> >> >
> >> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> >> > Cc: stable@dpdk.org
> >> >
> >> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> >> > ---
> >> > devtools/check-symbol-change.sh | 1 +
> >> > 1 file changed, 1 insertion(+)
> >> >
> >> > diff --git a/devtools/check-symbol-change.sh
> >> b/devtools/check-symbol-change.sh
> >> > index 8da7650..d5fad04 100755
> >> > --- a/devtools/check-symbol-change.sh
> >> > +++ b/devtools/check-symbol-change.sh
> >> > @@ -32,6 +32,7 @@ build_map_changes()
> >> > # symbol rule below
> >> > /^.*{/ {
> >> > gsub("+", "");
> >> > + gsub("-", "");
> >> > if (in_map == 1) {
> >> > sec=$(NF-1); in_sec=1;
> >> > }
> >> > --
> >> > 1.8.3.1
> >> >
> >> >
> >> Don't you also need to add some logic in the symbol detection match rule
> >> to
> >> print an appropriate indicator that a symbol is being removed? With just
> >> this
> >> change, you will note that you are parsing a section, but you will never
> >> trigger
> >> a symbol match
> >>
> >
> > I do remember seeing a warning about the "-EXPERIMENTAL" section.
> > And this is why I added this.
> > But since then I reorganised my series and eliminated some parts... so you
> > are most likely right.
> > I will double check and repost.
> >
> >
> Yes, you are right, I moved this out of another patch that I ended up not
> sending.
> But it makes no sense by itself.
> I will drop this in v2.
>
> Any comments on the other patches ?
> Thanks Neil.
>
No, I don't think I do, thanks for checking though!
Neil
>
> --
> David Marchand
^ permalink raw reply [flat|nested] 22+ messages in thread
* [dpdk-dev] [PATCH 3/4] devtools: fix symbol name in log message
2019-05-03 14:34 [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols David Marchand
2019-05-03 14:34 ` David Marchand
2019-05-03 14:34 ` [dpdk-dev] [PATCH 2/4] devtools: handle section suppression David Marchand
@ 2019-05-03 14:34 ` David Marchand
2019-05-03 14:34 ` David Marchand
2019-05-03 14:34 ` [dpdk-dev] [PATCH 4/4] devtools: fix direct additions to stable API David Marchand
2019-05-03 16:15 ` [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols Ray Kinsella
4 siblings, 1 reply; 22+ messages in thread
From: David Marchand @ 2019-05-03 14:34 UTC (permalink / raw)
To: dev; +Cc: thomas, nhorman, stable
We have an incorrect variable name in this log.
Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/check-symbol-change.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index d5fad04..9ada81e 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -98,7 +98,7 @@ check_for_rule_violations()
then
# Just inform the user of this occurrence, but
# don't flag it as an error
- echo -n "INFO: symbol $syname is added but "
+ echo -n "INFO: symbol $symname is added but "
echo -n "patch has insuficient context "
echo -n "to determine the section name "
echo -n "please ensure the version is "
--
1.8.3.1
^ permalink raw reply [flat|nested] 22+ messages in thread* [dpdk-dev] [PATCH 3/4] devtools: fix symbol name in log message
2019-05-03 14:34 ` [dpdk-dev] [PATCH 3/4] devtools: fix symbol name in log message David Marchand
@ 2019-05-03 14:34 ` David Marchand
0 siblings, 0 replies; 22+ messages in thread
From: David Marchand @ 2019-05-03 14:34 UTC (permalink / raw)
To: dev; +Cc: thomas, nhorman, stable
We have an incorrect variable name in this log.
Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/check-symbol-change.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index d5fad04..9ada81e 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -98,7 +98,7 @@ check_for_rule_violations()
then
# Just inform the user of this occurrence, but
# don't flag it as an error
- echo -n "INFO: symbol $syname is added but "
+ echo -n "INFO: symbol $symname is added but "
echo -n "patch has insuficient context "
echo -n "to determine the section name "
echo -n "please ensure the version is "
--
1.8.3.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* [dpdk-dev] [PATCH 4/4] devtools: fix direct additions to stable API
2019-05-03 14:34 [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols David Marchand
` (2 preceding siblings ...)
2019-05-03 14:34 ` [dpdk-dev] [PATCH 3/4] devtools: fix symbol name in log message David Marchand
@ 2019-05-03 14:34 ` David Marchand
2019-05-03 14:34 ` David Marchand
2019-05-09 21:40 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-03 16:15 ` [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols Ray Kinsella
4 siblings, 2 replies; 22+ messages in thread
From: David Marchand @ 2019-05-03 14:34 UTC (permalink / raw)
To: dev; +Cc: thomas, nhorman, stable
The incriminated commit broke the detection of new symbols skipping the
EXPERIMENTAL step before entering a stable abi section.
sed won't return an error, check a null output instead.
Fixes: 3630757803ab ("devtools: accept experimental symbol promotion")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/check-symbol-change.sh | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 9ada81e..116c311 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -111,15 +111,24 @@ check_for_rule_violations()
# A symbol can not enter a non experimental
# section directly
- if [ $? -ne 0 ] && [ "$secname" != 'EXPERIMENTAL' ]
+ if [ -z "$oldsecname" ]
then
- echo -n "ERROR: symbol $symname "
- echo -n "is added in the $secname "
- echo -n "section, but is expected to "
- echo -n "be added in the EXPERIMENTAL "
- echo "section of the version map"
- ret=1
- continue
+ if [ "$secname" = 'EXPERIMENTAL' ]
+ then
+ echo -n "INFO: symbol $symname has "
+ echo -n "been added to the "
+ echo -n "EXPERIMENTAL section of the "
+ echo "version map"
+ continue
+ else
+ echo -n "ERROR: symbol $symname "
+ echo -n "is added in the $secname "
+ echo -n "section, but is expected to "
+ echo -n "be added in the EXPERIMENTAL "
+ echo "section of the version map"
+ ret=1
+ continue
+ fi
fi
# This symbol is moving inside a section, nothing to do
--
1.8.3.1
^ permalink raw reply [flat|nested] 22+ messages in thread* [dpdk-dev] [PATCH 4/4] devtools: fix direct additions to stable API
2019-05-03 14:34 ` [dpdk-dev] [PATCH 4/4] devtools: fix direct additions to stable API David Marchand
@ 2019-05-03 14:34 ` David Marchand
2019-05-09 21:40 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
1 sibling, 0 replies; 22+ messages in thread
From: David Marchand @ 2019-05-03 14:34 UTC (permalink / raw)
To: dev; +Cc: thomas, nhorman, stable
The incriminated commit broke the detection of new symbols skipping the
EXPERIMENTAL step before entering a stable abi section.
sed won't return an error, check a null output instead.
Fixes: 3630757803ab ("devtools: accept experimental symbol promotion")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/check-symbol-change.sh | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 9ada81e..116c311 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -111,15 +111,24 @@ check_for_rule_violations()
# A symbol can not enter a non experimental
# section directly
- if [ $? -ne 0 ] && [ "$secname" != 'EXPERIMENTAL' ]
+ if [ -z "$oldsecname" ]
then
- echo -n "ERROR: symbol $symname "
- echo -n "is added in the $secname "
- echo -n "section, but is expected to "
- echo -n "be added in the EXPERIMENTAL "
- echo "section of the version map"
- ret=1
- continue
+ if [ "$secname" = 'EXPERIMENTAL' ]
+ then
+ echo -n "INFO: symbol $symname has "
+ echo -n "been added to the "
+ echo -n "EXPERIMENTAL section of the "
+ echo "version map"
+ continue
+ else
+ echo -n "ERROR: symbol $symname "
+ echo -n "is added in the $secname "
+ echo -n "section, but is expected to "
+ echo -n "be added in the EXPERIMENTAL "
+ echo "section of the version map"
+ ret=1
+ continue
+ fi
fi
# This symbol is moving inside a section, nothing to do
--
1.8.3.1
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH 4/4] devtools: fix direct additions to stable API
2019-05-03 14:34 ` [dpdk-dev] [PATCH 4/4] devtools: fix direct additions to stable API David Marchand
2019-05-03 14:34 ` David Marchand
@ 2019-05-09 21:40 ` Thomas Monjalon
2019-05-09 21:40 ` Thomas Monjalon
1 sibling, 1 reply; 22+ messages in thread
From: Thomas Monjalon @ 2019-05-09 21:40 UTC (permalink / raw)
To: David Marchand; +Cc: stable, dev, nhorman
03/05/2019 16:34, David Marchand:
> The incriminated commit broke the detection of new symbols skipping the
> EXPERIMENTAL step before entering a stable abi section.
> sed won't return an error, check a null output instead.
>
> Fixes: 3630757803ab ("devtools: accept experimental symbol promotion")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Series applied (without patch 2), thanks
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH 4/4] devtools: fix direct additions to stable API
2019-05-09 21:40 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
@ 2019-05-09 21:40 ` Thomas Monjalon
0 siblings, 0 replies; 22+ messages in thread
From: Thomas Monjalon @ 2019-05-09 21:40 UTC (permalink / raw)
To: David Marchand; +Cc: stable, dev, nhorman
03/05/2019 16:34, David Marchand:
> The incriminated commit broke the detection of new symbols skipping the
> EXPERIMENTAL step before entering a stable abi section.
> sed won't return an error, check a null output instead.
>
> Fixes: 3630757803ab ("devtools: accept experimental symbol promotion")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Series applied (without patch 2), thanks
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols
2019-05-03 14:34 [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols David Marchand
` (3 preceding siblings ...)
2019-05-03 14:34 ` [dpdk-dev] [PATCH 4/4] devtools: fix direct additions to stable API David Marchand
@ 2019-05-03 16:15 ` Ray Kinsella
2019-05-03 16:15 ` Ray Kinsella
2019-05-03 17:12 ` David Marchand
4 siblings, 2 replies; 22+ messages in thread
From: Ray Kinsella @ 2019-05-03 16:15 UTC (permalink / raw)
To: dev
Hi David,
Do you have this script wired into the DPDK CI?
Or is this purely for testing before packaging?
Ray K
On 03/05/2019 15:34, David Marchand wrote:
> No need to shout when we are just reordering symbols in a section.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> devtools/check-symbol-change.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index 40eb953..8da7650 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -121,6 +121,12 @@ check_for_rule_violations()
> continue
> fi
>
> + # This symbol is moving inside a section, nothing to do
> + if [ "$oldsecname" = "$secname" ]
> + then
> + continue
> + fi
> +
> # This symbol is moving between two sections (the
> # original section is not experimental).
> # This can be legit, just warn.
>
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols
2019-05-03 16:15 ` [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols Ray Kinsella
@ 2019-05-03 16:15 ` Ray Kinsella
2019-05-03 17:12 ` David Marchand
1 sibling, 0 replies; 22+ messages in thread
From: Ray Kinsella @ 2019-05-03 16:15 UTC (permalink / raw)
To: dev
Hi David,
Do you have this script wired into the DPDK CI?
Or is this purely for testing before packaging?
Ray K
On 03/05/2019 15:34, David Marchand wrote:
> No need to shout when we are just reordering symbols in a section.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> devtools/check-symbol-change.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index 40eb953..8da7650 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -121,6 +121,12 @@ check_for_rule_violations()
> continue
> fi
>
> + # This symbol is moving inside a section, nothing to do
> + if [ "$oldsecname" = "$secname" ]
> + then
> + continue
> + fi
> +
> # This symbol is moving between two sections (the
> # original section is not experimental).
> # This can be legit, just warn.
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols
2019-05-03 16:15 ` [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols Ray Kinsella
2019-05-03 16:15 ` Ray Kinsella
@ 2019-05-03 17:12 ` David Marchand
2019-05-03 17:12 ` David Marchand
1 sibling, 1 reply; 22+ messages in thread
From: David Marchand @ 2019-05-03 17:12 UTC (permalink / raw)
To: Ray Kinsella; +Cc: dev
Hello Ray,
On Fri, May 3, 2019 at 6:16 PM Ray Kinsella <mdr@ashroe.eu> wrote:
> Do you have this script wired into the DPDK CI?
> Or is this purely for testing before packaging?
>
Iirc, Thomas has this script running on the server side.
See for example the report for this very patch on the dpdk-test ml:
http://mails.dpdk.org/archives/test-report/2019-May/081948.html
Which is seen in patchwork as:
http://patchwork.dpdk.org/patch/53255/
"ci/checkpatch success coding style OK"
--
David Marchand
^ permalink raw reply [flat|nested] 22+ messages in thread