DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ayuj Verma <ayverma@marvell.com>
To: <akhil.goyal@nxp.com>, <arkadiuszx.kusztal@intel.com>,
	<fiona.trahe@intel.com>
Cc: <shallyv@marvell.com>, <ssahu@marvell.com>,
	<kkotamarthy@marvell.com>, <adesai@marvell.com>, <dev@dpdk.org>,
	Ayuj Verma <ayverma@marvell.com>
Subject: [dpdk-dev] [PATCH v4] fix return value for skipped tests
Date: Thu, 9 May 2019 16:53:20 +0530	[thread overview]
Message-ID: <1557401001-27203-1-git-send-email-ayverma@marvell.com> (raw)

Currently some tests return TEST_SKIPPED/-1 when tests or params
are not supported for particular PMD because of which tests adds to
FAILED test counter in place of Skipped/Unsupported counter.

Since unsupported test is not a failure case,
replace return value TEST_SKIPPED/-1 with -ENOTSUP

Changes in v4:
	- add reason for change as part of commit message log

Changes in v3:
        - retain '-1' for app error.
        - add NULL check for rte_cryptodev_asym_capability_get()
        - Typo correction

Changes in v2:
        - Replace TEST_SKIPPED/-1 with -ENOTSUP

Ayuj Verma (1):
  app/test: replace TEST_SKIPPED with -ENOTSUP

 app/test/test_cryptodev_asym.c | 45 ++++++++++++++++++++++++++++++------------
 1 file changed, 32 insertions(+), 13 deletions(-)

-- 
1.8.3.1

             reply	other threads:[~2019-05-09 11:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09 11:23 Ayuj Verma [this message]
2019-05-09 11:23 ` Ayuj Verma
2019-05-09 11:23 ` [dpdk-dev] [PATCH v4] app/test: replace TEST_SKIPPED with -ENOTSUP Ayuj Verma
2019-05-09 11:23   ` Ayuj Verma
2019-05-09 14:27   ` Thomas Monjalon
2019-05-09 14:27     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1557401001-27203-1-git-send-email-ayverma@marvell.com \
    --to=ayverma@marvell.com \
    --cc=adesai@marvell.com \
    --cc=akhil.goyal@nxp.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=kkotamarthy@marvell.com \
    --cc=shallyv@marvell.com \
    --cc=ssahu@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).