From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A426149DF; Fri, 10 May 2019 11:10:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 02:10:11 -0700 X-ExtLoop1: 1 Received: from dpdk6.bj.intel.com ([172.16.182.192]) by orsmga005.jf.intel.com with ESMTP; 10 May 2019 02:10:09 -0700 From: Wei Zhao To: dev@dpdk.org Cc: stable@dpdk.org, yuan.peng@intel.com, ferruh.yigit@intel.com, wenzhuo.lu@intel.com, Wei Zhao Date: Fri, 10 May 2019 16:41:17 +0800 Message-Id: <1557477677-54876-1-git-send-email-wei.zhao1@intel.com> X-Mailer: git-send-email 2.7.5 In-Reply-To: <1557386426-57149-1-git-send-email-wei.zhao1@intel.com> References: <1557386426-57149-1-git-send-email-wei.zhao1@intel.com> Subject: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 May 2019 09:10:13 -0000 There is no need to do such a check when set macsec for ixgbe, reconfig_device_queueand is also useless. If we do not delete this unnessary code, users have to sotp port before enable or disable macsec, then restart this port after make configuration. All these process is useless. As this cmdline is a private API which is only used by ixgbe NIC, so remove it. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Wei Zhao --- v2: -update log info and delete code in disable function --- app/test-pmd/cmdline.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index c1042dd..dd0f698 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed( if (port_id_is_invalid(port_id, ENABLED_WARN)) return; - if (!port_is_stopped(port_id)) { - printf("Please stop port %d first\n", port_id); - return; - } rte_eth_dev_info_get(port_id, &dev_info); if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) { @@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed( case 0: ports[port_id].dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_MACSEC_INSERT; - cmd_reconfig_device_queue(port_id, 1, 1); break; case -ENODEV: printf("invalid port_id %d\n", port_id); @@ -14138,10 +14133,6 @@ cmd_set_macsec_offload_off_parsed( if (port_id_is_invalid(port_id, ENABLED_WARN)) return; - if (!port_is_stopped(port_id)) { - printf("Please stop port %d first\n", port_id); - return; - } rte_eth_dev_info_get(port_id, &dev_info); if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) { @@ -14153,7 +14144,6 @@ cmd_set_macsec_offload_off_parsed( case 0: ports[port_id].dev_conf.txmode.offloads &= ~DEV_TX_OFFLOAD_MACSEC_INSERT; - cmd_reconfig_device_queue(port_id, 1, 1); break; case -ENODEV: printf("invalid port_id %d\n", port_id); -- 2.7.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1E400A0096 for ; Fri, 10 May 2019 11:10:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 611284CA6; Fri, 10 May 2019 11:10:14 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A426149DF; Fri, 10 May 2019 11:10:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 02:10:11 -0700 X-ExtLoop1: 1 Received: from dpdk6.bj.intel.com ([172.16.182.192]) by orsmga005.jf.intel.com with ESMTP; 10 May 2019 02:10:09 -0700 From: Wei Zhao To: dev@dpdk.org Cc: stable@dpdk.org, yuan.peng@intel.com, ferruh.yigit@intel.com, wenzhuo.lu@intel.com, Wei Zhao Date: Fri, 10 May 2019 16:41:17 +0800 Message-Id: <1557477677-54876-1-git-send-email-wei.zhao1@intel.com> X-Mailer: git-send-email 2.7.5 In-Reply-To: <1557386426-57149-1-git-send-email-wei.zhao1@intel.com> References: <1557386426-57149-1-git-send-email-wei.zhao1@intel.com> Subject: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190510084117.ZLs6cuCyQO_L1IRlTFDOeEubWooN-WBbipvcGl13s2w@z> There is no need to do such a check when set macsec for ixgbe, reconfig_device_queueand is also useless. If we do not delete this unnessary code, users have to sotp port before enable or disable macsec, then restart this port after make configuration. All these process is useless. As this cmdline is a private API which is only used by ixgbe NIC, so remove it. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Wei Zhao --- v2: -update log info and delete code in disable function --- app/test-pmd/cmdline.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index c1042dd..dd0f698 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed( if (port_id_is_invalid(port_id, ENABLED_WARN)) return; - if (!port_is_stopped(port_id)) { - printf("Please stop port %d first\n", port_id); - return; - } rte_eth_dev_info_get(port_id, &dev_info); if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) { @@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed( case 0: ports[port_id].dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_MACSEC_INSERT; - cmd_reconfig_device_queue(port_id, 1, 1); break; case -ENODEV: printf("invalid port_id %d\n", port_id); @@ -14138,10 +14133,6 @@ cmd_set_macsec_offload_off_parsed( if (port_id_is_invalid(port_id, ENABLED_WARN)) return; - if (!port_is_stopped(port_id)) { - printf("Please stop port %d first\n", port_id); - return; - } rte_eth_dev_info_get(port_id, &dev_info); if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) { @@ -14153,7 +14144,6 @@ cmd_set_macsec_offload_off_parsed( case 0: ports[port_id].dev_conf.txmode.offloads &= ~DEV_TX_OFFLOAD_MACSEC_INSERT; - cmd_reconfig_device_queue(port_id, 1, 1); break; case -ENODEV: printf("invalid port_id %d\n", port_id); -- 2.7.5