From: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
To: dev@dpdk.org, fiona.trahe@intel.com, tomaszx.jozwiak@intel.com,
shallyv@marvell.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on integer endianness
Date: Mon, 20 May 2019 15:26:04 +0200 [thread overview]
Message-ID: <1558358764-32053-2-git-send-email-tomaszx.jozwiak@intel.com> (raw)
In-Reply-To: <1558358764-32053-1-git-send-email-tomaszx.jozwiak@intel.com>
This patch fixes coverity issue:
Reliance on integer endianness (INCOMPATIBLE_CAST)
in parse_window_sz function.
Coverity issue: 328524
Fixes: e0b6287c035d ("app/compress-perf: add parser")
Cc: stable@dpdk.org
Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
---
app/test-compress-perf/comp_perf_options_parse.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/test-compress-perf/comp_perf_options_parse.c b/app/test-compress-perf/comp_perf_options_parse.c
index 2fb6fb4..56ca580 100644
--- a/app/test-compress-perf/comp_perf_options_parse.c
+++ b/app/test-compress-perf/comp_perf_options_parse.c
@@ -364,13 +364,15 @@ parse_max_num_sgl_segs(struct comp_test_data *test_data, const char *arg)
static int
parse_window_sz(struct comp_test_data *test_data, const char *arg)
{
- int ret = parse_uint16_t((uint16_t *)&test_data->window_sz, arg);
+ uint16_t tmp;
+ int ret = parse_uint16_t(&tmp, arg);
if (ret) {
RTE_LOG(ERR, USER1, "Failed to parse window size\n");
return -1;
}
+ test_data->window_sz = (int)tmp;
return 0;
}
--
2.7.4
next prev parent reply other threads:[~2019-05-20 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 13:26 [dpdk-dev] [PATCH] app/test-compress-perf: fix improper use of negative value Tomasz Jozwiak
2019-05-20 13:26 ` Tomasz Jozwiak [this message]
2019-05-20 14:05 ` [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on integer endianness Trahe, Fiona
2019-05-20 14:25 ` Jozwiak, TomaszX
2019-05-21 6:47 ` Jozwiak, TomaszX
2019-05-21 8:03 ` Shally Verma
2019-05-21 8:47 ` Jozwiak, TomaszX
2019-05-29 13:46 ` Trahe, Fiona
2019-06-03 13:44 ` Shally Verma
2019-05-20 13:39 ` [dpdk-dev] [PATCH] app/test-compress-perf: fix improper use of negative value Trahe, Fiona
2019-06-19 14:55 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558358764-32053-2-git-send-email-tomaszx.jozwiak@intel.com \
--to=tomaszx.jozwiak@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=shallyv@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).