From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 5F1322C4B for ; Thu, 27 Apr 2017 11:20:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B6BB620A19; Thu, 27 Apr 2017 05:20:23 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 27 Apr 2017 05:20:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=CodRwzA9X6vfbQI zTDGshGeDSNogrJySc/LOn/lbTBI=; b=Hb7BY2hLMI009xjM1fRD0/ggavfwp// Fmvsunvz9KcA8Q1FqzAlcsV5fSqksZKsjlAKxLUnkpuISyqGN4bebNetC2txHWdD pYKLGuc95c//GoUqYRgz0J4HBbgsz0TguJQ8lYNvoi6UWNq0wB9wRRzyFDGG6ere 72UJxdtNJgRU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=CodRwzA9X6vfbQIzTDGshGeDSNogrJySc/LOn/lbTBI=; b=I14yhIXy P8B6t+v3k0Tx106lStwssmGsZZnCs/EoNmrkc3kPXFFhy+7Yk5LE7GVYz15q+6R/ hTyhwD5VBWNBguK1JlLPuw0VWN++tyO78yhmQQkkM2lAFdf208caX5zs/Tkt/s+o RBjBctNUDDpKsrFyUegqXy0eJP3yuwlyo5pQSWpiD6JJw6tVluMvRQl+NgSToLw1 rd7EhiRfZnE1o6oeMMxi/WQx9opVoRV78hrUy/j14Pq7hrqWmETDob2exmJVo6ia Q68uP/XTGdppnFUngD9C0mrGeL9Unu8AAR4h3B1GweDBBZBfBC/UWqi0a2eb0FsY 9AI0XYWhA22JXQ== X-ME-Sender: X-Sasl-enc: 7HPs6jScGZRiKsF50CKN4VKMfv4KEXcdYv8iRp9g/+B2 1493284823 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 616D07E670; Thu, 27 Apr 2017 05:20:23 -0400 (EDT) From: Thomas Monjalon To: "Wang, Zhihong" Cc: "Richardson, Bruce" , dev@dpdk.org, yuanhan.liu@linux.intel.com Date: Thu, 27 Apr 2017 11:20:22 +0200 Message-ID: <1558565.2fZJ5xpf6Y@xps> In-Reply-To: <8F6C2BD409508844A0EFC19955BE09415126F7FE@SHSMSX103.ccr.corp.intel.com> References: <1493310859-49106-1-git-send-email-zhihong.wang@intel.com> <2616350.yKybQRU0rL@xps> <8F6C2BD409508844A0EFC19955BE09415126F7FE@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 09:20:31 -0000 27/04/2017 11:18, Wang, Zhihong: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 27/04/2017 18:34, Zhihong Wang: > > > Making AVX and AVX512 configurable is useful for performance and power > > > testing. > > > > > > The similar kernel patch at https://patchwork.kernel.org/patch/9618883/. > > [...] > > > +# > > > +# Recognize/ignore the AVX/AVX512 CPU flags for performance/power > > testing > > > +# > > > +CONFIG_RTE_ENABLE_AVX=y > > > +CONFIG_RTE_ENABLE_AVX512=n > > > > It is disabling AVX512 in default configuration. > > Please explain this behaviour change. > > Though AVX512 rte_memcpy has been in DPDK for quite a while it's still > unproven in hardware with rich use cases. Mark it as experimental for > now, user can enable it for their own testing. > > Will enable it with enough field tests and possible optimization. > > Should I add the explanation in commit log, or comments in the source, > or both? Yes please, add the explanation in the commit log and experimental comment in the config.