DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/i40e: Fail rte_flow MARK requests if RX func was vectorized
@ 2019-05-23 17:57 Mesut Ali Ergin
  2019-05-24  2:48 ` Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: Mesut Ali Ergin @ 2019-05-23 17:57 UTC (permalink / raw)
  To: Beilei Xing, Qi Zhang; +Cc: dev, Mesut Ali Ergin

Runtime requests to install an rte_flow with MARK action should fail
if a vector RX function was already chosen for the device during
configuration time.

Currently, i40e rte_flow driver would successfully install the flow
with MARK action, even when vector RX functions are in use. However,
those vector RX functions will fail to retrieve the MARK data from the
device descriptor into the mbuf. The original app  installing the flow
would never know what went wrong. The change introduced in this patch
must be reverted if/when vector RX functions start supporting correct
FDIR processing for MARK actions.

Signed-off-by: Mesut Ali Ergin <mesut.a.ergin@intel.com>
---
 drivers/net/i40e/i40e_flow.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 3afd779..9a14a1c 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -22,6 +22,7 @@
 #include "base/i40e_type.h"
 #include "base/i40e_prototype.h"
 #include "i40e_ethdev.h"
+#include "i40e_rxtx.h"
 
 #define I40E_IPV6_TC_MASK	(0xFF << I40E_FDIR_IPv6_TC_OFFSET)
 #define I40E_IPV6_FRAG_HEADER	44
@@ -3079,6 +3080,16 @@ i40e_flow_parse_fdir_action(struct rte_eth_dev *dev,
 		filter->action.behavior = I40E_FDIR_PASSTHRU;
 		break;
 	case RTE_FLOW_ACTION_TYPE_MARK:
+		if (dev->rx_pkt_burst == i40e_recv_scattered_pkts_vec ||
+		    dev->rx_pkt_burst == i40e_recv_pkts_vec ||
+		    dev->rx_pkt_burst == i40e_recv_scattered_pkts_vec_avx2 ||
+		    dev->rx_pkt_burst == i40e_recv_pkts_vec_avx2) {
+			/* Vector RX Functions do not support MARK*/
+			rte_flow_error_set(error, EINVAL,
+					   RTE_FLOW_ERROR_TYPE_ACTION, act,
+					   "Action not supported when vector RX is in use.");
+			return -rte_errno;
+		}
 		filter->action.behavior = I40E_FDIR_PASSTHRU;
 		mark_spec = act->conf;
 		filter->action.report_status = I40E_FDIR_REPORT_ID;
@@ -3103,6 +3114,16 @@ i40e_flow_parse_fdir_action(struct rte_eth_dev *dev,
 			   "Invalid action.");
 			return -rte_errno;
 		}
+		if (dev->rx_pkt_burst == i40e_recv_scattered_pkts_vec ||
+		    dev->rx_pkt_burst == i40e_recv_pkts_vec ||
+		    dev->rx_pkt_burst == i40e_recv_scattered_pkts_vec_avx2 ||
+		    dev->rx_pkt_burst == i40e_recv_pkts_vec_avx2) {
+			/* Vector RX Functions do not support MARK*/
+			rte_flow_error_set(error, EINVAL,
+					   RTE_FLOW_ERROR_TYPE_ACTION, act,
+					   "Action not supported when vector RX is in use.");
+			return -rte_errno;
+		}
 		mark_spec = act->conf;
 		filter->action.report_status = I40E_FDIR_REPORT_ID;
 		filter->soft_id = mark_spec->id;
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-24 22:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 17:57 [dpdk-dev] [PATCH] net/i40e: Fail rte_flow MARK requests if RX func was vectorized Mesut Ali Ergin
2019-05-24  2:48 ` Zhang, Qi Z
2019-05-24 22:47   ` Ergin, Mesut A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).