* [dpdk-dev] [PATCH] net/i40e: uninitialized value fixed in i40e_flow_parse_fdir_action
@ 2019-06-06 16:30 Mesut Ali Ergin
2019-06-06 19:58 ` Kevin Traynor
0 siblings, 1 reply; 3+ messages in thread
From: Mesut Ali Ergin @ 2019-06-06 16:30 UTC (permalink / raw)
To: beilei.xing, qi.z.zhang; +Cc: dev, Mesut Ali Ergin
Initializes mark_spec pointer to NULL.
Fixes: 0bbcfc706a2b ("net/i40e: support MARK and RSS flow action")
Coverity issue: 341075
Signed-off-by: Mesut Ali Ergin <mesut.a.ergin@intel.com>
---
drivers/net/i40e/i40e_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 9bfbea2..d62b32f 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -3052,7 +3052,7 @@ i40e_flow_parse_fdir_action(struct rte_eth_dev *dev,
struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
const struct rte_flow_action *act;
const struct rte_flow_action_queue *act_q;
- const struct rte_flow_action_mark *mark_spec;
+ const struct rte_flow_action_mark *mark_spec = NULL;
uint32_t index = 0;
/* Check if the first non-void action is QUEUE or DROP or PASSTHRU. */
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: uninitialized value fixed in i40e_flow_parse_fdir_action
2019-06-06 16:30 [dpdk-dev] [PATCH] net/i40e: uninitialized value fixed in i40e_flow_parse_fdir_action Mesut Ali Ergin
@ 2019-06-06 19:58 ` Kevin Traynor
2019-06-06 22:13 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Traynor @ 2019-06-06 19:58 UTC (permalink / raw)
To: Mesut Ali Ergin, beilei.xing, qi.z.zhang; +Cc: dev
On 06/06/2019 17:30, Mesut Ali Ergin wrote:
> Initializes mark_spec pointer to NULL.
>
> Fixes: 0bbcfc706a2b ("net/i40e: support MARK and RSS flow action")
> Coverity issue: 341075
>
> Signed-off-by: Mesut Ali Ergin <mesut.a.ergin@intel.com>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> drivers/net/i40e/i40e_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
> index 9bfbea2..d62b32f 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -3052,7 +3052,7 @@ i40e_flow_parse_fdir_action(struct rte_eth_dev *dev,
> struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> const struct rte_flow_action *act;
> const struct rte_flow_action_queue *act_q;
> - const struct rte_flow_action_mark *mark_spec;
> + const struct rte_flow_action_mark *mark_spec = NULL;
> uint32_t index = 0;
>
> /* Check if the first non-void action is QUEUE or DROP or PASSTHRU. */
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: uninitialized value fixed in i40e_flow_parse_fdir_action
2019-06-06 19:58 ` Kevin Traynor
@ 2019-06-06 22:13 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2019-06-06 22:13 UTC (permalink / raw)
To: Kevin Traynor, Ergin, Mesut A, Xing, Beilei; +Cc: dev
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Friday, June 7, 2019 3:58 AM
> To: Ergin, Mesut A <mesut.a.ergin@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: uninitialized value fixed in
> i40e_flow_parse_fdir_action
>
> On 06/06/2019 17:30, Mesut Ali Ergin wrote:
> > Initializes mark_spec pointer to NULL.
> >
> > Fixes: 0bbcfc706a2b ("net/i40e: support MARK and RSS flow action")
> > Coverity issue: 341075
> >
> > Signed-off-by: Mesut Ali Ergin <mesut.a.ergin@intel.com>
>
> Acked-by: Kevin Traynor <ktraynor@redhat.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-06 22:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 16:30 [dpdk-dev] [PATCH] net/i40e: uninitialized value fixed in i40e_flow_parse_fdir_action Mesut Ali Ergin
2019-06-06 19:58 ` Kevin Traynor
2019-06-06 22:13 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).