From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Don't inline string functions
Date: Wed, 14 May 2014 17:47:01 +0200 [thread overview]
Message-ID: <1559974.KXN93MZ8m0@xps13> (raw)
In-Reply-To: <20140514081932.37847146@nehalam.linuxnetplumber.net>
2014-05-14 08:19, Stephen Hemminger:
> It makes no sense to inline string functions, in fact snprintf
> can't be inlined because the function supports variable number of
> arguments.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> ---
> Resend because of lack of response
Please do not resend patches. I prefer a ping request in the original thread.
By the way, you didn't take into account my first comments:
http://dpdk.org/ml/archives/dev/2014-April/002028.html
and I'm still waiting answers to these patches:
http://dpdk.org/ml/archives/dev/2014-March/001673.html
http://dpdk.org/ml/archives/dev/2014-March/001676.html
PS: I was going to apply your patches with these fixes:
add FILE argument to debug functions
[Thomas: fix quota_watermark example]
eal: dont inline string functions
[Thomas: update includes]
--
Thomas
next prev parent reply other threads:[~2014-05-14 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 15:19 Stephen Hemminger
2014-05-14 15:29 ` Richardson, Bruce
2014-05-14 15:47 ` Thomas Monjalon [this message]
2014-05-14 16:41 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559974.KXN93MZ8m0@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).