From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id D3EBEB0A5
 for <dev@dpdk.org>; Wed, 14 May 2014 17:46:55 +0200 (CEST)
Received: by mail-wg0-f51.google.com with SMTP id x13so2137515wgg.10
 for <dev@dpdk.org>; Wed, 14 May 2014 08:47:03 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=Rl1317dQ8oeLup+thq7kWa9H4Jt2ys2SNqpC0ZYSI0I=;
 b=l00O8T4wBXwH7na1I9nuhnc+VWEUD6v/oa16/c1Q+gha7YhW9WxBGpGNBJxlV4RDM6
 u7CPXh/l5UJvQrVajGIO1O/vPC1xiLCgkzJJhi4TczQk2pNuKuFrvU22Yyg/DAMor9Pm
 jYBdoXat97kpUJzfBjnpVI7TMnwPVrg5CaDVf5c1sm7BlcgrDZz5my39gW77OmFY4o/N
 +ucqKMt0s47UElj0K8lciidBxnU99ah32wi5UxsHqxd3z3MFsviM/ty6D0CUdg8h6q16
 jqpeWu7C+WGcBH3pVmKr04hNfL0MyTTyrKEmxZQID5arbhbUFo3k/ndU7DKQUK5imLje
 KXLw==
X-Gm-Message-State: ALoCoQkRc+h1Eth1QkOA46U6QSm0936e/0l3diAoDgLomETyBmodUXjgsG/zmCV4MpkhsobGjhAH
X-Received: by 10.180.80.69 with SMTP id p5mr4135811wix.54.1400082423512;
 Wed, 14 May 2014 08:47:03 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id by1sm2977289wjc.26.2014.05.14.08.47.01
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 14 May 2014 08:47:02 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 14 May 2014 17:47:01 +0200
Message-ID: <1559974.KXN93MZ8m0@xps13>
Organization: 6WIND
User-Agent: KMail/4.13 (Linux/3.14.3-2-ARCH; KDE/4.13.0; x86_64; ; )
In-Reply-To: <20140514081932.37847146@nehalam.linuxnetplumber.net>
References: <20140514081932.37847146@nehalam.linuxnetplumber.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Don't inline string functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 May 2014 15:46:56 -0000

2014-05-14 08:19, Stephen Hemminger:
> It makes no sense to inline string functions, in fact snprintf
> can't be inlined because the function supports variable number of
> arguments.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> ---
> Resend because of lack of response

Please do not resend patches. I prefer a ping request in the original thread.

By the way, you didn't take into account my first comments:
	http://dpdk.org/ml/archives/dev/2014-April/002028.html
and I'm still waiting answers to these patches:
	http://dpdk.org/ml/archives/dev/2014-March/001673.html
	http://dpdk.org/ml/archives/dev/2014-March/001676.html

PS: I was going to apply your patches with these fixes:
	add FILE argument to debug functions
		[Thomas: fix quota_watermark example]
	eal: dont inline string functions
		[Thomas: update includes]

-- 
Thomas