DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/vhost: fix redundant queue state event
@ 2019-06-19  6:16 Noa Ezra
  2019-06-20  6:33 ` [dpdk-dev] [PATCH v2] " Noa Ezra
  2019-06-25  7:04 ` [dpdk-dev] [Suspected-Phishing][PATCH] " Noa Ezra
  0 siblings, 2 replies; 10+ messages in thread
From: Noa Ezra @ 2019-06-19  6:16 UTC (permalink / raw)
  To: maxime.coquelin; +Cc: matan, dev, noae, stable

In some situations, when a virtual machine is starting,
vring_state_changed can be called while there was no change in the
queue state. This fix makes sure that there was really a change in the
queue state before calling the callback for EVENT_QUEUE_STATE.

Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
Cc: stable@dpdk.org
Reviewed-by: Matan Azrad <matan@mellanox.com>
---
 drivers/net/vhost/rte_eth_vhost.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index cad1e5c..fbe7a37 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -855,6 +855,10 @@ struct vhost_xstats_name_off {
 	/* won't be NULL */
 	state = vring_states[eth_dev->data->port_id];
 	rte_spinlock_lock(&state->lock);
+	if (state->cur[vring] == enable) {
+		rte_spinlock_unlock(&state->lock);
+		return 0;
+	}
 
 	state->cur[vring] = enable;
 	state->max_vring = RTE_MAX(vring, state->max_vring);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-09-27  9:49 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19  6:16 [dpdk-dev] [PATCH] net/vhost: fix redundant queue state event Noa Ezra
2019-06-20  6:33 ` [dpdk-dev] [PATCH v2] " Noa Ezra
2019-09-27  8:49   ` Maxime Coquelin
2019-09-27  9:49     ` Maxime Coquelin
2019-06-25  7:04 ` [dpdk-dev] [Suspected-Phishing][PATCH] " Noa Ezra
2019-06-25  8:23   ` Maxime Coquelin
2019-06-26  6:37     ` Noa Ezra
2019-06-26  7:01       ` Maxime Coquelin
2019-06-26  8:03         ` Noa Ezra
2019-06-26  8:54           ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).