From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75FDCA0487 for ; Mon, 1 Jul 2019 07:47:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5F7E5B3C; Mon, 1 Jul 2019 07:47:06 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 053145424 for ; Mon, 1 Jul 2019 07:47:03 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x615jB1W026048 for ; Sun, 30 Jun 2019 22:47:03 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0818; bh=D3BDlOmfZ6zsYHA+9MyNObMki/5zzLm6tbwZcBfggf8=; b=GCmy1cPL5Evle4RfB+M0MfU2GCJboOkXOjsykLE7L6/BKgTbk1Gh4JzkwWJDJ//qwAlo GDSwvQlnwFeAHsjLLEjzYJAj5gVgGShp21amtmsQU9knr1au4+ky1dr2kap2rRtMOC3l aHQ7q/GJOkKOaRTHDKhBMeCjMLSQtbFmjVCkqCwcxAryA6K6PwALJIfASxuh+cZoRhF2 ZZEQztrBoOTICRh9VghMqFWvbvB+siVayK9N3X4ayUj5wEAm/n0dOnfewHk0dzPpyv8D /xnHLQ9Vg4+di3yxNbKoi7DKcPXb7FdI3uEWKG8ZHRXQjHaDWdTg2b5zHz5PwPrItPXO 4Q== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2te5bn656h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Sun, 30 Jun 2019 22:47:03 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sun, 30 Jun 2019 22:47:02 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Sun, 30 Jun 2019 22:47:02 -0700 Received: from pt-lxl0023.marvell.com (pt-lxl0023.marvell.com [10.5.213.12]) by maili.marvell.com (Postfix) with ESMTP id 31F0A3F7040; Sun, 30 Jun 2019 22:47:00 -0700 (PDT) From: To: CC: , Liron Himi Date: Mon, 1 Jul 2019 11:00:22 +0300 Message-ID: <1561968024-16133-2-git-send-email-lironh@marvell.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1561968024-16133-1-git-send-email-lironh@marvell.com> References: <1560434305-9359-1-git-send-email-lironh@marvell.com> <1561968024-16133-1-git-send-email-lironh@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-01_04:, , signatures=0 Subject: [dpdk-dev] [PATCH v3 1/3] net/mvneta: fix: ierror counted twice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Liron Himi error packets were counted twice due to use of redundant counters Fixes: e9d5faff ("net/mvneta: support basic stats") Signed-off-by: Liron Himi Reviewed-by: Yuri Chipchev Tested-by: Liron Himi --- drivers/net/mvneta/mvneta_ethdev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c index 9657444..d6e64a8 100644 --- a/drivers/net/mvneta/mvneta_ethdev.c +++ b/drivers/net/mvneta/mvneta_ethdev.c @@ -707,10 +707,7 @@ mvneta_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->imissed += ppio_stats.rx_discard + ppio_stats.rx_overrun - priv->prev_stats.imissed; - - stats->ierrors = ppio_stats.rx_packets_err + - ppio_stats.rx_errors + - ppio_stats.rx_crc_error - + stats->ierrors = ppio_stats.rx_packets_err - priv->prev_stats.ierrors; stats->oerrors = ppio_stats.tx_errors - priv->prev_stats.oerrors; -- 2.7.4