* [dpdk-dev] [PATCH] lib/librte_hash: fix incorrect comment for lookup
@ 2018-04-12 12:33 Shreyansh Jain
2018-04-12 14:27 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: Shreyansh Jain @ 2018-04-12 12:33 UTC (permalink / raw)
To: bruce.richardson, pablo.de.lara.guarch; +Cc: dev, Shreyansh Jain
rte_hash_lookup_with_hash() has wrong comment for its 'sig' param.
Fixes: 1a9f648be291 ("hash: fix for multi-process apps")
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
lib/librte_hash/rte_hash.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
index 3beaca71c..f71ca9fbf 100644
--- a/lib/librte_hash/rte_hash.h
+++ b/lib/librte_hash/rte_hash.h
@@ -328,7 +328,7 @@ rte_hash_lookup(const struct rte_hash *h, const void *key);
* @param key
* Key to find.
* @param sig
- * Hash value to remove from the hash table.
+ * Precomputed hash value for 'key'.
* @return
* - -EINVAL if the parameters are invalid.
* - -ENOENT if the key is not found.
--
2.14.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/librte_hash: fix incorrect comment for lookup
2018-04-12 12:33 [dpdk-dev] [PATCH] lib/librte_hash: fix incorrect comment for lookup Shreyansh Jain
@ 2018-04-12 14:27 ` De Lara Guarch, Pablo
2018-04-15 13:08 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2018-04-12 14:27 UTC (permalink / raw)
To: Shreyansh Jain, Richardson, Bruce; +Cc: dev, stable
> -----Original Message-----
> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com]
> Sent: Thursday, April 12, 2018 1:34 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; Shreyansh Jain <shreyansh.jain@nxp.com>
> Subject: [PATCH] lib/librte_hash: fix incorrect comment for lookup
>
> rte_hash_lookup_with_hash() has wrong comment for its 'sig' param.
>
> Fixes: 1a9f648be291 ("hash: fix for multi-process apps")
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Also, this should be backported to the stable branch, so I CC stable@dpdk.org.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/librte_hash: fix incorrect comment for lookup
2018-04-12 14:27 ` De Lara Guarch, Pablo
@ 2018-04-15 13:08 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-04-15 13:08 UTC (permalink / raw)
To: Shreyansh Jain; +Cc: dev, De Lara Guarch, Pablo, Richardson, Bruce, stable
> > rte_hash_lookup_with_hash() has wrong comment for its 'sig' param.
> >
> > Fixes: 1a9f648be291 ("hash: fix for multi-process apps")
> >
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Also, this should be backported to the stable branch, so I CC stable@dpdk.org.
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-15 13:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 12:33 [dpdk-dev] [PATCH] lib/librte_hash: fix incorrect comment for lookup Shreyansh Jain
2018-04-12 14:27 ` De Lara Guarch, Pablo
2018-04-15 13:08 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).