From: Fiona Trahe <fiona.trahe@intel.com>
To: dev@dpdk.org
Cc: akhil.goyal@nxp.com, fiona.trahe@intel.com
Subject: [dpdk-dev] [PATCH] test/compress: clarify out-of-space error messages
Date: Fri, 5 Jul 2019 18:19:10 +0100 [thread overview]
Message-ID: <1562347150-19022-1-git-send-email-fiona.trahe@intel.com> (raw)
Use ERR rather than INFO to warn that it's a negative test else
the errors are seen but the warning to expect them isn't.
Also add comment to make it easier to follow code.
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
app/test/test_compressdev.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
index cf78775..65889c2 100644
--- a/app/test/test_compressdev.c
+++ b/app/test/test_compressdev.c
@@ -1870,7 +1870,7 @@ struct test_data_params {
uint16_t i;
const struct rte_compressdev_capabilities *capab;
- RTE_LOG(INFO, USER1, "This is a negative test errors are expected\n");
+ RTE_LOG(ERR, USER1, "This is a negative test errors are expected\n");
capab = rte_compressdev_capability_get(0, RTE_COMP_ALGO_DEFLATE);
TEST_ASSERT(capab != NULL, "Failed to retrieve device capabilities");
@@ -1901,7 +1901,7 @@ struct test_data_params {
RTE_COMP_OP_STATELESS,
LB_BOTH,
ZLIB_DECOMPRESS,
- 1,
+ 1, /* run out-of-space test */
0
};
/* Compress with compressdev, decompress with Zlib */
--
1.7.0.7
next reply other threads:[~2019-07-05 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 17:19 Fiona Trahe [this message]
[not found] ` <522B1A062D56224ABC0C6BDBCD64D9D32F3E58A8@irsmsx105.ger.corp.intel.com>
2019-07-18 12:39 ` Dybkowski, AdamX
2019-07-18 15:24 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562347150-19022-1-git-send-email-fiona.trahe@intel.com \
--to=fiona.trahe@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).