From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 40AA02B9C for ; Tue, 27 Mar 2018 18:11:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B5ECF20F77; Tue, 27 Mar 2018 12:11:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 27 Mar 2018 12:11:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=N9d5BZ5Uh0GQYbylI9V+UkpJrO YGrCOMggJNvXm3esM=; b=J3oXLXFIEUNC0qmwslp8jXHojQmNDcLURG9UplScLp k3jvLCbRR31LFJS2bOBFwQ+kDeOcsk5CVIWbc6IdAAd0EGVHcRFPP5emhhpCZa4G 3levRkOaEOzZm9qSj6PHML4j8+U9ys2vk/xXaQKK7gHL8F/38THcgDZscyN3VtiZ M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=N9d5BZ 5Uh0GQYbylI9V+UkpJrOYGrCOMggJNvXm3esM=; b=Z9tLfQBk8kYgcWVK2loi6J Arl1GQdFfYqGlc+RcIiNNjSjJlI9KzMv1mWgNKP83yhtmKR0IisO6ELwzIYusjNY uSjspc/X5xmLXiwUie+j30EWmgCuRU38N/DmlcaG46No3Sbb902+HIt5fpITaLih 6Euk31VcntR1ajqQ64Ahr5eVWqQaa0cWBE7wIoFmeuV+CH8XxvQH7HlocJ5TWEjx ir/3qptKIaWWQUa9eeLzBu2NdKEKg/WUMxFRFpFiOkjuc7fGVoP+xTH8C9Ka5kaP QJH8+LSBTYWAEq18vazpvxG7glZgzVRaoFI9S0YdRBHY26gvgT3WDLU8y3ZEesXg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7B2EBE4488; Tue, 27 Mar 2018 12:11:28 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, anatoly.burakov@intel.com, lironh@marvell.com, bruce.richardson@intel.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com Date: Tue, 27 Mar 2018 18:11:13 +0200 Message-ID: <1562446.8uNvKBYxys@xps> In-Reply-To: <20180326075344.2209-1-pbhagavatula@caviumnetworks.com> References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com> <20180326075344.2209-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/2] drivers: add common folder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 16:11:30 -0000 26/03/2018 09:53, Pavan Nikhilesh: > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -3,18 +3,19 @@ > > include $(RTE_SDK)/mk/rte.vars.mk > > +DIRS-y += common > DIRS-y += bus > DIRS-y += mempool > -DEPDIRS-mempool := bus > +DEPDIRS-mempool := bus common > DIRS-y += net > -DEPDIRS-net := bus mempool > +DEPDIRS-net := bus common mempool > DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += bbdev > -DEPDIRS-bbdev := bus mempool > +DEPDIRS-bbdev := bus common mempool > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto > -DEPDIRS-crypto := bus mempool > +DEPDIRS-crypto := bus common mempool > DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event > -DEPDIRS-event := bus mempool net > +DEPDIRS-event := bus common mempool net > DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += raw > -DEPDIRS-raw := bus mempool net event > +DEPDIRS-raw := bus common mempool net event > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -2,11 +2,12 @@ > # Copyright(c) 2017 Intel Corporation > > # Defines the order in which the drivers are buit. > -driver_classes = ['bus', > - 'mempool', # depends on bus. > - 'net', # depends on bus and mempool. > - 'crypto', # depenss on bus, mempool (net in future). > - 'event'] # depends on bus, mempool and net. > +driver_classes = ['common', > + 'bus', > + 'mempool', # depends on bus and common. > + 'net', # depends on bus, common and mempool. > + 'crypto', # depenss on bus, common and mempool (net in future). > + 'event'] # depends on bus, common, mempool and net. It seems you used alphabetical order to list dependencies in the Makefile and in meson.build. I think it would be more logical to have common before bus in dependencies. You can also take the opportunity to fix the typo on "depenss". Thanks