[dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2

[dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2

[Gavin Hu]

Since gcc-8.3(I tried 8.3 and 9.1), the meson build failed on ThunderX2.
It got the following compiling errors:
/usr/lib/gcc/aarch64-linux-gnu/9/include/arm_neon.h:26493:1: error:
inlining failed in call to always_inline ‘vmull_p64’: target specific
option mismatch 26493 | vmull_p64 (poly64_t a, poly64_t b)

Fixes: 7286c9d7234f ("config: add thunderx2 machine")
Cc: jerinj@marvell.com
Cc: stable@dpdk.org

Signed-off-by: Gavin Hu <gavin.hu@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Jingzhao Ni <jingzhao.ni@arm.com>
---
 config/arm/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 6fa06a1..979018e 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -95,7 +95,7 @@ machine_args_cavium = [
 	['0xa1', ['-mcpu=thunderxt88'], flags_thunderx_extra],
 	['0xa2', ['-mcpu=thunderxt81'], flags_thunderx_extra],
 	['0xa3', ['-mcpu=thunderxt83'], flags_thunderx_extra],
-	['0xaf', ['-mcpu=thunderx2t99'], flags_thunderx2_extra],
+	['0xaf', ['-march=armv8.1-a+crc+crypto','-mcpu=thunderx2t99'], flags_thunderx2_extra],
 	['0xb2', ['-mcpu=octeontx2'], flags_octeontx2_extra]]
 
 ## Arm implementer ID (ARM DDI 0487C.a, Section G7.2.106, Page G7-5321)
-- 
2.7.4

Re: [dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2

[Jerin Jacob Kollanukkaran]

> -----Original Message-----
> From: Gavin Hu <gavin.hu@arm.com>
> Sent: Friday, July 12, 2019 3:29 PM
> To: dev@dpdk.org
> Cc: nd@arm.com; thomas@monjalon.net; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Honnappa.Nagarahalli@arm.com;
> gavin.hu@arm.com; stable@dpdk.org
> Subject: [EXT] [PATCH] config: fix meson build failure on ThunderX2
> 
> Since gcc-8.3(I tried 8.3 and 9.1), the meson build failed on ThunderX2.
> It got the following compiling errors:
> /usr/lib/gcc/aarch64-linux-gnu/9/include/arm_neon.h:26493:1: error:
> inlining failed in call to always_inline ‘vmull_p64’: target specific option
> mismatch 26493 | vmull_p64 (poly64_t a, poly64_t b)
> 
> Fixes: 7286c9d7234f ("config: add thunderx2 machine")
> Cc: jerinj@marvell.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Jingzhao Ni <jingzhao.ni@arm.com>

Thanks Gavin.
Able to reproduce this issue with gcc 9.1 and proposed patch fixing the issue as well.

Acked-by: Jerin Jacob <jerinj@marvell.com>

Re: [dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2

[Honnappa Nagarahalli]

> >
> > Since gcc-8.3(I tried 8.3 and 9.1), the meson build failed on ThunderX2.
> > It got the following compiling errors:
> > /usr/lib/gcc/aarch64-linux-gnu/9/include/arm_neon.h:26493:1: error:
> > inlining failed in call to always_inline ‘vmull_p64’: target specific
> > option mismatch 26493 | vmull_p64 (poly64_t a, poly64_t b)
> >
> > Fixes: 7286c9d7234f ("config: add thunderx2 machine")
> > Cc: jerinj@marvell.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > Reviewed-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Jingzhao Ni <jingzhao.ni@arm.com>
> 
> Thanks Gavin.
> Able to reproduce this issue with gcc 9.1 and proposed patch fixing the issue as
> well.
Jerin, any reason for not enabling LSE on ThunderX2?

> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Re: [dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2

[Jerin Jacob Kollanukkaran]

> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: Friday, July 12, 2019 10:10 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Gavin Hu (Arm
> Technology China) <Gavin.Hu@arm.com>; dev@dpdk.org
> Cc: nd <nd@arm.com>; thomas@monjalon.net; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; stable@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
> Subject: [EXT] RE: [PATCH] config: fix meson build failure on ThunderX2
> > > Since gcc-8.3(I tried 8.3 and 9.1), the meson build failed on ThunderX2.
> > > It got the following compiling errors:
> > > /usr/lib/gcc/aarch64-linux-gnu/9/include/arm_neon.h:26493:1: error:
> > > inlining failed in call to always_inline ‘vmull_p64’: target
> > > specific option mismatch 26493 | vmull_p64 (poly64_t a, poly64_t b)
> > >
> > > Fixes: 7286c9d7234f ("config: add thunderx2 machine")
> > > Cc: jerinj@marvell.com
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > > Reviewed-by: Phil Yang <phil.yang@arm.com>
> > > Reviewed-by: Jingzhao Ni <jingzhao.ni@arm.com>
> >
> > Thanks Gavin.
> > Able to reproduce this issue with gcc 9.1 and proposed patch fixing
> > the issue as well.
> Jerin, any reason for not enabling LSE on ThunderX2?

LSE is enabled when -mcpu=thunderx2t99 selected.

$ aarch64-linux-gnu-gcc  -mcpu=thunderx2t99 -dM -E - </dev/null | grep __ARM_FEATURE_ATOMICS
#define __ARM_FEATURE_ATOMICS 1

> 
> >
> > Acked-by: Jerin Jacob <jerinj@marvell.com>

Re: [dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2

[Honnappa Nagarahalli]

<snip>

Subject: [EXT] RE: [PATCH] config: fix meson build failure on
> > ThunderX2
> > > > Since gcc-8.3(I tried 8.3 and 9.1), the meson build failed on ThunderX2.
> > > > It got the following compiling errors:
> > > > /usr/lib/gcc/aarch64-linux-gnu/9/include/arm_neon.h:26493:1: error:
> > > > inlining failed in call to always_inline ‘vmull_p64’: target
> > > > specific option mismatch 26493 | vmull_p64 (poly64_t a, poly64_t
> > > > b)
> > > >
> > > > Fixes: 7286c9d7234f ("config: add thunderx2 machine")
> > > > Cc: jerinj@marvell.com
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > > > Reviewed-by: Phil Yang <phil.yang@arm.com>
> > > > Reviewed-by: Jingzhao Ni <jingzhao.ni@arm.com>
> > >
> > > Thanks Gavin.
> > > Able to reproduce this issue with gcc 9.1 and proposed patch fixing
> > > the issue as well.
> > Jerin, any reason for not enabling LSE on ThunderX2?
> 
> LSE is enabled when -mcpu=thunderx2t99 selected.
> 
> $ aarch64-linux-gnu-gcc  -mcpu=thunderx2t99 -dM -E - </dev/null | grep
> __ARM_FEATURE_ATOMICS #define __ARM_FEATURE_ATOMICS 1

This does not work with older GCC versions [1]. They need LSE enabled explicitly.

[1] https://godbolt.org/z/2nmASR

> 
> >
> > >
> > > Acked-by: Jerin Jacob <jerinj@marvell.com>

Re: [dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2

[Jerin Jacob Kollanukkaran]

> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: Monday, July 15, 2019 7:55 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Gavin Hu (Arm
> Technology China) <Gavin.Hu@arm.com>; dev@dpdk.org
> Cc: nd <nd@arm.com>; thomas@monjalon.net; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; stable@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
> Subject: [EXT] RE: [PATCH] config: fix meson build failure on ThunderX2
> 
> > > Jerin, any reason for not enabling LSE on ThunderX2?
> >
> > LSE is enabled when -mcpu=thunderx2t99 selected.
> >
> > $ aarch64-linux-gnu-gcc  -mcpu=thunderx2t99 -dM -E - </dev/null | grep
> > __ARM_FEATURE_ATOMICS #define __ARM_FEATURE_ATOMICS 1
> 
> This does not work with older GCC versions [1]. They need LSE enabled
> explicitly.
> 
> [1] https://godbolt.org/z/2nmASR

Looks like, you have selected "armv8-a+crc" not "armv8.1-a+crc" in the godbolt.
It comes properly with armv8.1-a+crc. Please check.

> 
> >
> > >
> > > >
> > > > Acked-by: Jerin Jacob <jerinj@marvell.com>

Re: [dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2

[Honnappa Nagarahalli]

> >
> > > > Jerin, any reason for not enabling LSE on ThunderX2?
> > >
> > > LSE is enabled when -mcpu=thunderx2t99 selected.
> > >
> > > $ aarch64-linux-gnu-gcc  -mcpu=thunderx2t99 -dM -E - </dev/null |
> > > grep __ARM_FEATURE_ATOMICS #define __ARM_FEATURE_ATOMICS 1
> >
> > This does not work with older GCC versions [1]. They need LSE enabled
> > explicitly.
> >
> > [1] https://godbolt.org/z/2nmASR
> 
> Looks like, you have selected "armv8-a+crc" not "armv8.1-a+crc" in the godbolt.
> It comes properly with armv8.1-a+crc. Please check.
Yes, works fine. Thanks.

> 
> >
> > >
> > > >
> > > > >
> > > > > Acked-by: Jerin Jacob <jerinj@marvell.com>