From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96406A0471 for ; Tue, 16 Jul 2019 08:24:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F6542BF5; Tue, 16 Jul 2019 08:24:42 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id B4E491B53 for ; Tue, 16 Jul 2019 08:24:40 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6G6OdWI031978; Mon, 15 Jul 2019 23:24:40 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=pfpt0818; bh=Exn4Iy8p9jvMBbO64zcxrDBS1hBBByeDh9ow0j16R/Q=; b=fCS6+wL24OfsykuTIf3qpjVmQB8e6IullCBcV4Dlv++XzOaQHrOf6ZtyzmdoUTML/6TW tN4n10qLS+QheREjjlJiWQ2svG4S/a09Q3e3j8y1QQQZJkybzL/6sbPYFrVl5X6QSnWA QAPqRfgF5vJ8g4k9TUAP/d/ESwBgQhN3cOwSI8jHFeuLXzBVC2coLE7OJ4vrmkvWuntP HOsCHgOg2A5lTgHALAfcEFlIASZJB2ZMDo2C4gePYShI8GWvdP2wdigaD6YmBkdR6mfG h+3iTXxdgvMpzRMvtgjZGW2bgO4+pX9GIw5IfF7UxE/nBPrS8EEI8FmX1acq3BYqDbRx Mw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2ts0a21sur-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 15 Jul 2019 23:24:39 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 15 Jul 2019 23:23:33 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Mon, 15 Jul 2019 23:23:33 -0700 Received: from dc7-eodlnx05.marvell.com (dc7-eodlnx05.marvell.com [10.28.113.55]) by maili.marvell.com (Postfix) with ESMTP id 315FF3F703F; Mon, 15 Jul 2019 23:23:31 -0700 (PDT) From: Sunil Kumar Kori To: Konstantin Ananyev CC: , Sunil Kumar Kori Date: Tue, 16 Jul 2019 11:53:28 +0530 Message-ID: <1563258209-2114-1-git-send-email-skori@marvell.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-16_02:2019-07-16,2019-07-16 signatures=0 Subject: [dpdk-dev] [PATCH v2 1/1] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags during fragmentation operation implicitly by the library. Because of this, application is forced to use checksum offload whether it is supported by platform or not. Also documentation does not provide any expected value of ol_flags in returned fragmented mbufs so application will never come to know that which offloads are enabled. So transmission may be failed for the platforms which does not support checksum offload. So removing mentioned flag from the library. Mentioned changeset is part of http://patches.dpdk.org/patch/53475/ Changes for reassembly operation is already accepcted. This patch set implements the similar change for fragmentation operation. Signed-off-by: Sunil Kumar Kori --- Current patch is part of following patchset http://patches.dpdk.org/patch/53475/ which is missed to be merged into upstream because of accepted version of this patch does not contain this change. Accepted patchset is given below: http://patches.dpdk.org/patch/56202/ Patchset is already reviewed and acked on maillist. Also corrersponding release notes are updated. lib/librte_ip_frag/rte_ipv4_fragmentation.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_ip_frag/rte_ipv4_fragmentation.c b/lib/librte_ip_frag/rte_ipv4_fragmentation.c index 221d74e..9e9f986 100644 --- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c +++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c @@ -173,7 +173,6 @@ static inline void __free_fragments(struct rte_mbuf *mb[], uint32_t num) fragment_offset = (uint16_t)(fragment_offset + out_pkt->pkt_len - sizeof(struct rte_ipv4_hdr)); - out_pkt->ol_flags |= PKT_TX_IP_CKSUM; out_pkt->l3_len = sizeof(struct rte_ipv4_hdr); /* Write the fragment to the output list */ -- 1.8.3.1