From: Ed Czeck <ed.czeck@atomicrules.com>
To: dev@dpdk.org, ferruh.yigit@intel.com
Cc: shepard.siegel@atomicrules.com, john.miller@atomicrules.com,
Ed Czeck <ed.czeck@atomicrules.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id
Date: Fri, 19 Jul 2019 09:07:42 -0400 [thread overview]
Message-ID: <1563541663-10797-1-git-send-email-ed.czeck@atomicrules.com> (raw)
In-Reply-To: <1563312861-26219-1-git-send-email-ed.czeck@atomicrules.com>
Queue index was incorrectly incremented with port, which
caused swizzling of packet placement among queues. This manifested
when the number of configured ports was >1 and < nb_queues.
Fixes: c33d45af3633 ("net/ark: add Tx initial version")
Cc: stable@dpdk.org
Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
---
drivers/net/ark/ark_ethdev_rx.c | 4 +---
drivers/net/ark/ark_ethdev_tx.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c
index 7de1a98..6156730 100644
--- a/drivers/net/ark/ark_ethdev_rx.c
+++ b/drivers/net/ark/ark_ethdev_rx.c
@@ -127,9 +127,7 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev,
uint32_t i;
int status;
- /* Future works: divide the Q's evenly with multi-ports */
- int port = dev->data->port_id;
- int qidx = port + queue_idx;
+ int qidx = queue_idx;
/* We may already be setup, free memory prior to re-allocation */
if (dev->data->rx_queues[queue_idx] != NULL) {
diff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c
index 1967655..08bcf43 100644
--- a/drivers/net/ark/ark_ethdev_tx.c
+++ b/drivers/net/ark/ark_ethdev_tx.c
@@ -211,9 +211,7 @@ eth_ark_tx_queue_setup(struct rte_eth_dev *dev,
struct ark_tx_queue *queue;
int status;
- /* Future: divide the Q's evenly with multi-ports */
- int port = dev->data->port_id;
- int qidx = port + queue_idx;
+ int qidx = queue_idx;
if (!rte_is_power_of_2(nb_desc)) {
PMD_DRV_LOG(ERR,
--
2.7.4
next prev parent reply other threads:[~2019-07-19 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 21:34 Ed Czeck
2019-07-16 21:34 ` [dpdk-dev] [PATCH 2/2] net/ark: remove resources when port is close Ed Czeck
2019-07-17 17:33 ` [dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id Ferruh Yigit
2019-07-19 13:07 ` Ed Czeck [this message]
2019-07-19 13:07 ` [dpdk-dev] [PATCH 2/2] net/ark: remove resources when port is close Ed Czeck
2019-07-19 17:27 ` [dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id Ferruh Yigit
2019-07-22 12:35 ` Ed Czeck
2019-07-22 12:35 ` [dpdk-dev] [PATCH 2/2] net/ark: remove resources when port is close Ed Czeck
2019-07-22 16:07 ` [dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563541663-10797-1-git-send-email-ed.czeck@atomicrules.com \
--to=ed.czeck@atomicrules.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.miller@atomicrules.com \
--cc=shepard.siegel@atomicrules.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).