From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Ivan Malov <ivan.malov@oktetlabs.ru>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names
Date: Thu, 18 Jan 2018 10:24:55 +0100 [thread overview]
Message-ID: <1563746.HlMJDYb8UE@xps> (raw)
In-Reply-To: <49b1556b-b1ec-2264-1450-1887c3290c4f@solarflare.com>
18/01/2018 08:52, Andrew Rybchenko:
> On 01/18/2018 10:16 AM, Andrew Rybchenko wrote:
> > On 01/17/2018 08:33 PM, Thomas Monjalon wrote:
> >> Hi, 2 comments below
> >>
> >> 11/01/2018 09:12, Andrew Rybchenko:
> >>> From: Ivan Malov <ivan.malov@oktetlabs.ru>
> >>>
> >>> +#define RTE_RX_OFFLOAD_BIT2STR(_name) \
> >>> + { DEV_RX_OFFLOAD_##_name, #_name }
> >>> +
> >>> +static const struct {
> >>> + uint64_t offload;
> >>> + const char *name;
> >>> +} rte_rx_offload_names[] = {
> >>> + RTE_RX_OFFLOAD_BIT2STR(VLAN_STRIP),
> >>> + RTE_RX_OFFLOAD_BIT2STR(IPV4_CKSUM),
> >>> + RTE_RX_OFFLOAD_BIT2STR(UDP_CKSUM),
> >>> + RTE_RX_OFFLOAD_BIT2STR(TCP_CKSUM),
> >>> + RTE_RX_OFFLOAD_BIT2STR(TCP_LRO),
> >>> + RTE_RX_OFFLOAD_BIT2STR(QINQ_STRIP),
> >>> + RTE_RX_OFFLOAD_BIT2STR(OUTER_IPV4_CKSUM),
> >>> + RTE_RX_OFFLOAD_BIT2STR(MACSEC_STRIP),
> >>> + RTE_RX_OFFLOAD_BIT2STR(HEADER_SPLIT),
> >>> + RTE_RX_OFFLOAD_BIT2STR(VLAN_FILTER),
> >>> + RTE_RX_OFFLOAD_BIT2STR(VLAN_EXTEND),
> >>> + RTE_RX_OFFLOAD_BIT2STR(JUMBO_FRAME),
> >>> + RTE_RX_OFFLOAD_BIT2STR(CRC_STRIP),
> >>> + RTE_RX_OFFLOAD_BIT2STR(SCATTER),
> >>> + RTE_RX_OFFLOAD_BIT2STR(TIMESTAMP),
> >>> + RTE_RX_OFFLOAD_BIT2STR(SECURITY),
> >>> +};
> >>> +
> >>> +#undef RTE_RX_OFFLOAD_BIT2STR
> >> Why this undef?
> >
> > It is a constant-local macro with assumption to be used as
>
> I mean context-local, sorry.
>
> > initializer of the corresponding structure. So, under is just to
> > limit its context and be sure that it is will not clash or be reused
> > most likely in a wrong way.
We do not take this precaution usually in DPDK.
No strong opinion however.
next prev parent reply other threads:[~2018-01-18 9:25 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 8:12 [dpdk-dev] [PATCH 0/6] net/sfc: convert to the new offload API Andrew Rybchenko
2018-01-11 8:12 ` [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names Andrew Rybchenko
2018-01-17 16:55 ` Ferruh Yigit
2018-01-17 17:06 ` Thomas Monjalon
2018-01-17 17:33 ` Thomas Monjalon
2018-01-18 6:32 ` Shahaf Shuler
2018-01-18 7:16 ` Andrew Rybchenko
2018-01-18 7:52 ` Andrew Rybchenko
2018-01-18 9:24 ` Thomas Monjalon [this message]
2018-01-11 8:12 ` [dpdk-dev] [PATCH 2/6] ethdev: add a function to look up Tx " Andrew Rybchenko
2018-01-11 8:12 ` [dpdk-dev] [PATCH 3/6] net/sfc: factor out function to report Rx capabilities Andrew Rybchenko
2018-01-11 8:12 ` [dpdk-dev] [PATCH 4/6] net/sfc: convert to the new Rx offload API Andrew Rybchenko
2018-01-11 8:12 ` [dpdk-dev] [PATCH 5/6] net/sfc: factor out function to report Tx capabilities Andrew Rybchenko
2018-01-11 8:12 ` [dpdk-dev] [PATCH 6/6] net/sfc: convert to the new Tx offload API Andrew Rybchenko
2018-01-17 16:55 ` [dpdk-dev] [PATCH 0/6] net/sfc: convert to the new " Ferruh Yigit
2018-01-18 7:02 ` [dpdk-dev] [PATCH v2 " Andrew Rybchenko
2018-01-18 7:02 ` [dpdk-dev] [PATCH v2 1/6] ethdev: add a function to look up Rx offload names Andrew Rybchenko
2018-01-18 7:02 ` [dpdk-dev] [PATCH v2 2/6] ethdev: add a function to look up Tx " Andrew Rybchenko
2018-01-18 7:02 ` [dpdk-dev] [PATCH v2 3/6] net/sfc: factor out function to report Rx capabilities Andrew Rybchenko
2018-01-18 7:02 ` [dpdk-dev] [PATCH v2 4/6] net/sfc: convert to the new Rx offload API Andrew Rybchenko
2018-01-18 7:02 ` [dpdk-dev] [PATCH v2 5/6] net/sfc: factor out function to report Tx capabilities Andrew Rybchenko
2018-01-18 7:02 ` [dpdk-dev] [PATCH v2 6/6] net/sfc: convert to the new Tx offload API Andrew Rybchenko
2018-01-18 7:07 ` [dpdk-dev] [PATCH v3 0/6] net/sfc: convert to the new " Andrew Rybchenko
2018-01-18 7:07 ` [dpdk-dev] [PATCH v3 1/6] ethdev: add a function to look up Rx offload names Andrew Rybchenko
2018-01-18 9:26 ` Thomas Monjalon
2018-01-18 9:47 ` Andrew Rybchenko
2018-01-18 7:07 ` [dpdk-dev] [PATCH v3 2/6] ethdev: add a function to look up Tx " Andrew Rybchenko
2018-01-18 7:07 ` [dpdk-dev] [PATCH v3 3/6] net/sfc: factor out function to report Rx capabilities Andrew Rybchenko
2018-01-18 7:07 ` [dpdk-dev] [PATCH v3 4/6] net/sfc: convert to the new Rx offload API Andrew Rybchenko
2018-01-18 7:07 ` [dpdk-dev] [PATCH v3 5/6] net/sfc: factor out function to report Tx capabilities Andrew Rybchenko
2018-01-18 7:07 ` [dpdk-dev] [PATCH v3 6/6] net/sfc: convert to the new Tx offload API Andrew Rybchenko
2018-01-18 9:44 ` [dpdk-dev] [PATCH v4 0/6] net/sfc: convert to the new " Andrew Rybchenko
2018-01-18 9:44 ` [dpdk-dev] [PATCH v4 1/6] ethdev: add a function to look up Rx offload names Andrew Rybchenko
2018-01-18 10:29 ` Thomas Monjalon
2018-01-18 9:44 ` [dpdk-dev] [PATCH v4 2/6] ethdev: add a function to look up Tx " Andrew Rybchenko
2018-01-18 10:30 ` Thomas Monjalon
2018-01-18 9:44 ` [dpdk-dev] [PATCH v4 3/6] net/sfc: factor out function to report Rx capabilities Andrew Rybchenko
2018-01-18 9:44 ` [dpdk-dev] [PATCH v4 4/6] net/sfc: convert to the new Rx offload API Andrew Rybchenko
2018-01-18 9:44 ` [dpdk-dev] [PATCH v4 5/6] net/sfc: factor out function to report Tx capabilities Andrew Rybchenko
2018-01-18 9:44 ` [dpdk-dev] [PATCH v4 6/6] net/sfc: convert to the new Tx offload API Andrew Rybchenko
2018-01-18 15:40 ` [dpdk-dev] [PATCH v4 0/6] net/sfc: convert to the new " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563746.HlMJDYb8UE@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).