From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by dpdk.org (Postfix) with ESMTP id 5B91FB460 for ; Wed, 22 Jun 2016 10:26:06 +0200 (CEST) Received: by mail-lf0-f52.google.com with SMTP id f6so65519621lfg.0 for ; Wed, 22 Jun 2016 01:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=s+T+xBNkZ203rHOl0FXKi1FKG7KOScAc2Jg97YmrAHs=; b=K96Em6hxMCYI4Y8zHHV2DPBXupo3G80wCNYBjCk36JOkvhO0TIvfObO0n339kewC5g 0Eb1OCF2+coCv+/iU+K04iPtPK6piulnK98jliCuAlWoxbLjafjrCHgi5SIgynyE7ziu tTRrovne1jwIHgJ/05h97tdj3v2mtmLRiDUss/JE8xJ84j5CzN5KDCYhP2AIW28yvrfU wqxaBeEaCz15O1W9oiohZ4zEYpglRoCi04KxM2gFYjL351I6Gm+/Ghdi3zRY1246XDjS DBoAijq8ZB31OeVUv9e1ykNBJXwSsK3/+OmPhPZa0dYoJaYemTMTomEV+F0NAwROYypk AQuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=s+T+xBNkZ203rHOl0FXKi1FKG7KOScAc2Jg97YmrAHs=; b=Af5zSSwdOi/DzhN/0ZT0WemWob8WjYXiqehDRDA9DmdDrGcGmpvHzUhoRaZwg2IK08 sw+6fjCzMQ7aICVBhRkC/A9XExJhk591BSe9l/Aor5Ov66clQ6cTFqJSsHVeFghAzfPK mzIpsQPzSDUELkIVEWwbqdsMYu9DdaUUg4SwpUWg3uOVRCFfIfT+Ft0KuQZJ0oTIIIyh z286IVcV9I0srWKxR+minPTHtNZLRRZXXZF6XNbsHfxlbmRjEI/eKlzcksyRL9lhxT5e eE3EJICFhhzdNlyNrVGVp9dBTIQWuJGxsQIIttXgn9W/fCa/6w3uA0sdB79PaopaK5E6 H+fw== X-Gm-Message-State: ALyK8tLAkFU8r/6VQ0oyEXUx3UcjMvSb3sRE+vznbFwzB4aYT/d6vTssMcKELuzLeUbpJGpZ X-Received: by 10.194.123.166 with SMTP id mb6mr4646359wjb.94.1466583965577; Wed, 22 Jun 2016 01:26:05 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id b77sm1719847wme.0.2016.06.22.01.26.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Jun 2016 01:26:04 -0700 (PDT) From: Thomas Monjalon To: Zyta Szpak Cc: Remy Horton , dev@dpdk.org Date: Wed, 22 Jun 2016 10:26:04 +0200 Message-ID: <1563787.cLWrTzMx7D@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <576A49FC.2090400@semihalf.com> References: <1464767771-19159-1-git-send-email-zr@semihalf.com> <57690F01.6020600@semihalf.com> <576A49FC.2090400@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2016 08:26:06 -0000 2016-06-22 10:19, Zyta Szpak: > Note that if we remove rte_eth_dev_get_reg_length() then it will break > all of the drivers that implement it. Shall I remove it all leave it and > modify only ethtool to use rte_eth_dev_get_regs() to get reg size? In > the end the drivers will have to implement the part of setting the size > in reg_info struct. rte_eth_dev_get_regs() itself wouldn't change at all. > Or do you have different opinion? igb, ixgbe and i40e must be updated in the same patch to comply with the new behaviour of rte_eth_dev_get_regs. rte_eth_dev_get_reg_length can be deprecated and removed in the next release. > On 21.06.2016 11:55, Zyta Szpak wrote: > > OK, I will do the v4. > > > > On 17.06.2016 12:20, Thomas Monjalon wrote: > >> 2016-06-13 16:51, Remy Horton: > >>> On 12/06/2016 15:51, Zyta Szpak wrote: > >>>> I would prefer having only one function rte_eth_dev_get_regs() > >>>> which returns length and width if data is NULL. > >>>> The first call is a parameter request before buffer allocation, > >>>> and the second call fills the buffer. > >>>> > >>>> We can deprecate the old API and introduce this new one. > >>>> > >>>> Opinions? > >>>> > >>>> In my opinion as it is now it works fine. Gathering all parameters in > >>>> one callback might be a good idea if the maintainer also agrees to > >>>> that > >>>> because as I mentioned, it interferes. > >>> From my perspective changing rte_eth_dev_get_regs() isn't a > >>> problem, as > >>> it isn't used directly rather than through rte_ethtool_get_regs().. > >> Zyta, would you like to make a v4? > > >