From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 571D73237 for ; Fri, 15 Jul 2016 22:18:50 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id f126so38427393wma.1 for ; Fri, 15 Jul 2016 13:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=fbUuWoLl+0xF4mwzy5zuen8kAES/TWFqa9Uyz5qc9fk=; b=p4SqYc6xkQIP8iA5RGA5qhay/ra920yf2UolWC2V5bs79VpzQwt9EEjRajauRjDdAk fcft4lXJr+OOcLIuXZw6fSSRoq1lN5QHDiFaCk7Yk4Eegob/V7sb4eDjCinh+fDP65kE E8oc7gYI27IZOpEH+a9cyKF2JdBb2cYDsF27YtO2mpyud0TtIOjPpqeMMaHLIdyjKc1R cZqlTgMK/8nTCkt5OxDh1eNoqswc1rsJ0PMoTxzja72GbeBs2y/CZ2+JFVXKZKbMYPqx W4cFaztbYrSgfJNBJXGsc3OhzH7jT12paQFgI53n3H83Kh0sYp+8L57eCAt0X/Gk9j0k E6og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=fbUuWoLl+0xF4mwzy5zuen8kAES/TWFqa9Uyz5qc9fk=; b=MxtcDX0I701e/d0gHHvuUgJqHkgsr9yYTKdQxHZltvUuxVx22aathl/LvFXSrzcaBg bTpWBIelhknW0XnRpMG0XCn1O3kTJtY+MV6TNmPHIkdoNppErFbDvf7T5W1Z/O7HjsJq rGF2dqh1YM9OFxt8fxiHyYMjXl94d3wrK2PwTvgGRS2VaelLIhUOxuCBMJw0YFXK66Yk /pQHUSaun2D36sRvVJjlDf5K5IBsiQHLqVW5qROp9O6UXOSKeK2YpndjhXZUEPRBZXZF E8Z3/rpc5rFun7RNWGcQXsmbyOn8+H9yEgDfcX+d+DINzC5AaeRdG/zC3EVFIMDKgZxG jkNw== X-Gm-Message-State: ALyK8tJPlQNCxt0nqSqVe1IcdtyD7WntIBOaNw9e++5ZIuqZqbhelnfZ1WaY14uwrJqU5n6z X-Received: by 10.28.154.208 with SMTP id c199mr29559119wme.102.1468613930141; Fri, 15 Jul 2016 13:18:50 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id f4sm1790697wmf.8.2016.07.15.13.18.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 13:18:49 -0700 (PDT) From: Thomas Monjalon To: Maxime Coquelin Cc: dev@dpdk.org, Yuanhan Liu , huawei.xie@intel.com, Jianfeng Tan Date: Fri, 15 Jul 2016 22:18:48 +0200 Message-ID: <1563829.pzlCzMBiVk@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160712121114.GF26521@yliu-dev.sh.intel.com> References: <1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com> <20160712121114.GF26521@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: Fix missing brackets in if condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 20:18:50 -0000 2016-07-12 20:11, Yuanhan Liu: > On Tue, Jul 12, 2016 at 11:30:25AM +0200, Maxime Coquelin wrote: > > The error is reported using test build script: > >=20 > > $ scripts/test-build.sh x86_64-native-linuxapp-gcc > > ... > > drivers/net/virtio/virtio_user_ethdev.c: In function =E2=80=98virti= o_user_pmd_devinit=E2=80=99: > > drivers/net/virtio/virtio_user_ethdev.c:345:2: error: this =E2=80=98= if=E2=80=99 clause does not guard... [-Werror=3Dmisleading-indentation]= > > if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) =3D=3D 1) > > ^~ > >=20 > > Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked= ") > >=20 > > Cc: Jianfeng Tan > > Signed-off-by: Maxime Coquelin >=20 > Acked-by: Yuanhan Liu >=20 > Thanks for the fix. Applied, thanks