* [dpdk-dev] [PATCH] app/test-pipeline: Fix table hash lru initialization
@ 2016-09-23 13:54 Guruprasad Rao
2016-09-23 14:37 ` Dumitrescu, Cristian
0 siblings, 1 reply; 3+ messages in thread
From: Guruprasad Rao @ 2016-09-23 13:54 UTC (permalink / raw)
To: dev; +Cc: sankarx.chokkalingam, cristian.dumitrescu, jasvinder.singh
macro ‘APP_METADATA_OFFSET’ was not used to initialize
‘signature_offset’ and ‘key_offset’ part of struct
rte_table_hash_lru_params.
Instead integer offset values were directly used.
with this fix 'hash-8-lru', 'hash-16-lru', 'hash-32-lru' table types are
able to forward traffic as expected.
Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark")
Signed-off-by: Sankar Chokkalingam <sankarx.chokkalingam@intel.com>
Signed-off-by: Guruprasad Rao <guruprasadx.rao@intel.com>
---
app/test-pipeline/pipeline_hash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pipeline/pipeline_hash.c b/app/test-pipeline/pipeline_hash.c
index f8aac0d..0e369a2 100644
--- a/app/test-pipeline/pipeline_hash.c
+++ b/app/test-pipeline/pipeline_hash.c
@@ -190,8 +190,8 @@ app_main_loop_worker_pipeline_hash(void) {
.n_buckets = 1 << 22,
.f_hash = test_hash,
.seed = 0,
- .signature_offset = 0,
- .key_offset = 32,
+ .signature_offset = APP_METADATA_OFFSET(0),
+ .key_offset = APP_METADATA_OFFSET(32),
};
struct rte_pipeline_table_params table_params = {
--
2.5.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/test-pipeline: Fix table hash lru initialization
2016-09-23 13:54 [dpdk-dev] [PATCH] app/test-pipeline: Fix table hash lru initialization Guruprasad Rao
@ 2016-09-23 14:37 ` Dumitrescu, Cristian
2016-09-23 17:22 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Dumitrescu, Cristian @ 2016-09-23 14:37 UTC (permalink / raw)
To: Rao, GuruprasadX, dev; +Cc: Chokkalingam, SankarX, Singh, Jasvinder
> -----Original Message-----
> From: Rao, GuruprasadX
> Sent: Friday, September 23, 2016 2:55 PM
> To: dev@dpdk.org
> Cc: Chokkalingam, SankarX <sankarx.chokkalingam@intel.com>; Dumitrescu,
> Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH] app/test-pipeline: Fix table hash lru initialization
>
> macro ‘APP_METADATA_OFFSET’ was not used to initialize
> ‘signature_offset’ and ‘key_offset’ part of struct
> rte_table_hash_lru_params.
> Instead integer offset values were directly used.
>
> with this fix 'hash-8-lru', 'hash-16-lru', 'hash-32-lru' table types are
> able to forward traffic as expected.
>
> Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark")
>
> Signed-off-by: Sankar Chokkalingam <sankarx.chokkalingam@intel.com>
> Signed-off-by: Guruprasad Rao <guruprasadx.rao@intel.com>
> ---
> app/test-pipeline/pipeline_hash.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/test-pipeline: Fix table hash lru initialization
2016-09-23 14:37 ` Dumitrescu, Cristian
@ 2016-09-23 17:22 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-09-23 17:22 UTC (permalink / raw)
To: Rao, GuruprasadX
Cc: dev, Dumitrescu, Cristian, Chokkalingam, SankarX, Singh, Jasvinder
> > macro ‘APP_METADATA_OFFSET’ was not used to initialize
> > ‘signature_offset’ and ‘key_offset’ part of struct
> > rte_table_hash_lru_params.
> > Instead integer offset values were directly used.
> >
> > with this fix 'hash-8-lru', 'hash-16-lru', 'hash-32-lru' table types are
> > able to forward traffic as expected.
> >
> > Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark")
> >
> > Signed-off-by: Sankar Chokkalingam <sankarx.chokkalingam@intel.com>
> > Signed-off-by: Guruprasad Rao <guruprasadx.rao@intel.com>
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-23 17:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-23 13:54 [dpdk-dev] [PATCH] app/test-pipeline: Fix table hash lru initialization Guruprasad Rao
2016-09-23 14:37 ` Dumitrescu, Cristian
2016-09-23 17:22 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).