Re: [dpdk-dev] [PATCH 3/3] librte_cfgfile: rework

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-05-29 17:26, Maciej Gajdzica:
> From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> 
> This patch add following features:
>  1. Make entry variable length - remove 64 byte limit.
>  2. Add line continue character '\' to make multiline values possible.
> 
> This patch also fixes following issues:
>  1. BUG: section were allocated as a block of memory. In rte_cfgfile_close()
>     free() was wrongly called on each section. This bug is fixed implicitly
>     by implementing new section allocation scheme.
>  2. Protect against multiple sections/entries in sections with the same
>     name.

Would it be possible to have separate patches for these 4 changes?

> 
> Implications:
>  1. Change in struct rte_cfgfile_entry deffinition.
>  2. Change in rte_cfgfile_section_entries() declaration.
> 
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
[...]
> --- a/lib/librte_cfgfile/rte_cfgfile_version.map
> +++ b/lib/librte_cfgfile/rte_cfgfile_version.map
> @@ -13,3 +13,11 @@ DPDK_2.0 {
>  
>  	local: *;
>  };
> +
> +DPDK_2.1 {
> +	global:
> +
> +	rte_cfgfile_section_entries;
> +
> +	local: *;
> +}

Syntax error. I should be
+} DPDK_2.0;

The example qos_sched must be updated, as it is now based on librte_cfgfile.

Thanks