From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id EC4485A65
 for <dev@dpdk.org>; Mon, 15 Jun 2015 11:30:32 +0200 (CEST)
Received: by wgez8 with SMTP id z8so63840279wge.0
 for <dev@dpdk.org>; Mon, 15 Jun 2015 02:30:32 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=LCzqKFFL9VNDr2WT49+XhC2ww+Jsc3RV4kT17qT7izE=;
 b=fXf3Dd7AYfcaZXiDYHgZXCEgPCpQ5ZNfDDOhPGlmeSrZgmTTRHOvGES1w/reagDk9i
 NOdgCjx9REy6cOPHd4pTiKrlTN/wjNiirsox8oRYM2kbv39BvS1qKjnQf0eId4by9778
 uX7Ca6VCeJo/V1Uayu0k3BmXLmPfq7wYWPhvHaNbuHRjsSVRLulsOAPxFYmDlQIU2f77
 g+lq9jE/KCxd6Wv4W9siA/Q5hbAxuM6F1bQlem8+8lkRmrc7rwixeejuQnJPAYkVlo/C
 xk629jxxvdRnfdLXcH7z/WoADLZkA76DCzipDad87PrlrxqlI3ZRuCOX2yQTGiG7/785
 fQPA==
X-Gm-Message-State: ALoCoQn1P/E71KPHLkm0+rNGpW1D1tibVFNZonHosZPOBaOaih0W6pRutNlbqhEztU71JaDJhPrS
X-Received: by 10.180.105.227 with SMTP id gp3mr29873301wib.56.1434360632788; 
 Mon, 15 Jun 2015 02:30:32 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id fi6sm14917949wib.6.2015.06.15.02.30.31
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 15 Jun 2015 02:30:32 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>,
 Pawel Wodkowski <pawelx.wodkowski@intel.com>
Date: Mon, 15 Jun 2015 11:29:35 +0200
Message-ID: <1563877.UnFfLhtCtX@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1432913219-11589-4-git-send-email-maciejx.t.gajdzica@intel.com>
References: <1432913219-11589-1-git-send-email-maciejx.t.gajdzica@intel.com>
 <1432913219-11589-4-git-send-email-maciejx.t.gajdzica@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] librte_cfgfile: rework
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Jun 2015 09:30:33 -0000

2015-05-29 17:26, Maciej Gajdzica:
> From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> 
> This patch add following features:
>  1. Make entry variable length - remove 64 byte limit.
>  2. Add line continue character '\' to make multiline values possible.
> 
> This patch also fixes following issues:
>  1. BUG: section were allocated as a block of memory. In rte_cfgfile_close()
>     free() was wrongly called on each section. This bug is fixed implicitly
>     by implementing new section allocation scheme.
>  2. Protect against multiple sections/entries in sections with the same
>     name.

Would it be possible to have separate patches for these 4 changes?

> 
> Implications:
>  1. Change in struct rte_cfgfile_entry deffinition.
>  2. Change in rte_cfgfile_section_entries() declaration.
> 
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
[...]
> --- a/lib/librte_cfgfile/rte_cfgfile_version.map
> +++ b/lib/librte_cfgfile/rte_cfgfile_version.map
> @@ -13,3 +13,11 @@ DPDK_2.0 {
>  
>  	local: *;
>  };
> +
> +DPDK_2.1 {
> +	global:
> +
> +	rte_cfgfile_section_entries;
> +
> +	local: *;
> +}

Syntax error. I should be
+} DPDK_2.0;

The example qos_sched must be updated, as it is now based on librte_cfgfile.

Thanks