From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BD53A046B for ; Thu, 25 Jul 2019 10:24:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 65FF01C2B0; Thu, 25 Jul 2019 10:24:28 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id C9D541C289; Thu, 25 Jul 2019 10:24:25 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6P8GEWT024957; Thu, 25 Jul 2019 01:24:24 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0818; bh=u0JVxcuQ4HcCf7I47exhpHY7HHmt1uU2NeaN4yDKqIg=; b=O/JIoTsGtqbKh9rrEqB815Cc5BmTO8bmmUeFYWMig1vrdQOZUFDAct1dA9it+b8Q9ILO gOk/92qpf1kGV/2hery0vBHCdHhKDix6RDKaQt7mtnsU7814ZRCIL2M3HXMiLYO96h/+ 2KvXW0pU7jiEJgG3Tkp0415TfkLx+3Ue65iBYA4eH+p2gi8BcEDEo/qAzUU0/9NCJzBn AjE3ErZNqnjwzLmb2XwYY0ibqG/OcsPzW1Z0InYwUJGl1u5Ss4zEqcZLQcZFvycVWJRp Ks48ulnTYjz6RXcZFVWrqDzwT4Xr6KBDfZgvJnn2gaswmDA57Y22qDQzRFW7AWviZX8h Pw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2tx61rgke6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 25 Jul 2019 01:24:24 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 25 Jul 2019 01:24:23 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 25 Jul 2019 01:24:23 -0700 Received: from dc7-eodlnx05.marvell.com (dc7-eodlnx05.marvell.com [10.28.113.55]) by maili.marvell.com (Postfix) with ESMTP id 4BF1B3F703F; Thu, 25 Jul 2019 01:24:21 -0700 (PDT) From: Sunil Kumar Kori To: Konstantin Ananyev CC: , , Sunil Kumar Kori Date: Thu, 25 Jul 2019 13:54:10 +0530 Message-ID: <1564043050-28306-1-git-send-email-skori@marvell.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1564034330-16321-1-git-send-email-skori@marvell.com> References: <1564034330-16321-1-git-send-email-skori@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-25_04:2019-07-25,2019-07-25 signatures=0 Subject: [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Application uses different pool to allocate direct and indirect mbufs which are further spliced together to consturct a fragmented packet and same is transmitted over the port which is configured with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments must belong to the same pool. But constructed packet violates the conditions. So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device configuration. Fixes: fdb9eff67f0c ("examples/ip_fragmentation: convert to new offloads API") Signed-off-by: Sunil Kumar Kori --- v3: - Add Fixes tag v2: - Subject is corrected. examples/ip_fragmentation/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c index 03be0c1..324d607 100644 --- a/examples/ip_fragmentation/main.c +++ b/examples/ip_fragmentation/main.c @@ -939,9 +939,6 @@ struct rte_lpm6_config lpm6_config = { n_tx_queue = nb_lcores; if (n_tx_queue > MAX_TX_QUEUE_PER_PORT) n_tx_queue = MAX_TX_QUEUE_PER_PORT; - if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) - local_port_conf.txmode.offloads |= - DEV_TX_OFFLOAD_MBUF_FAST_FREE; ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue, &local_port_conf); if (ret < 0) { -- 1.8.3.1