* [dpdk-dev] [PATCH] examples/ip_fragmentation: fix DEV_TX_OFFLOAD_MBUF_FAST_FREE flag
@ 2019-07-25 5:50 Sunil Kumar Kori
2019-07-25 5:58 ` [dpdk-dev] [PATCH v2 1/1] examples/ip_frag: " Sunil Kumar Kori
0 siblings, 1 reply; 7+ messages in thread
From: Sunil Kumar Kori @ 2019-07-25 5:50 UTC (permalink / raw)
To: Konstantin Ananyev; +Cc: dev, Sunil Kumar Kori
Application uses different pool to allocate direct and indirect
mbufs which are further spliced together to consturct a fragmented
packet and same is transmitted over the port which is configured
with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments
must belong to the same pool. But constructed packet violates
the conditions.
So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
configuration.
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
examples/ip_fragmentation/main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index 03be0c1..324d607 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -939,9 +939,6 @@ struct rte_lpm6_config lpm6_config = {
n_tx_queue = nb_lcores;
if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
n_tx_queue = MAX_TX_QUEUE_PER_PORT;
- if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
- local_port_conf.txmode.offloads |=
- DEV_TX_OFFLOAD_MBUF_FAST_FREE;
ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue,
&local_port_conf);
if (ret < 0) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH v2 1/1] examples/ip_frag: fix DEV_TX_OFFLOAD_MBUF_FAST_FREE flag
2019-07-25 5:50 [dpdk-dev] [PATCH] examples/ip_fragmentation: fix DEV_TX_OFFLOAD_MBUF_FAST_FREE flag Sunil Kumar Kori
@ 2019-07-25 5:58 ` Sunil Kumar Kori
2019-07-25 7:54 ` Ananyev, Konstantin
2019-07-25 8:24 ` [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag Sunil Kumar Kori
0 siblings, 2 replies; 7+ messages in thread
From: Sunil Kumar Kori @ 2019-07-25 5:58 UTC (permalink / raw)
To: Konstantin Ananyev; +Cc: dev, Sunil Kumar Kori
Application uses different pool to allocate direct and indirect
mbufs which are further spliced together to consturct a fragmented
packet and same is transmitted over the port which is configured
with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments
must belong to the same pool. But constructed packet violates
the conditions.
So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
configuration.
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
v2:
- Subject is corrected.
examples/ip_fragmentation/main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index 03be0c1..324d607 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -939,9 +939,6 @@ struct rte_lpm6_config lpm6_config = {
n_tx_queue = nb_lcores;
if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
n_tx_queue = MAX_TX_QUEUE_PER_PORT;
- if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
- local_port_conf.txmode.offloads |=
- DEV_TX_OFFLOAD_MBUF_FAST_FREE;
ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue,
&local_port_conf);
if (ret < 0) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v2 1/1] examples/ip_frag: fix DEV_TX_OFFLOAD_MBUF_FAST_FREE flag
2019-07-25 5:58 ` [dpdk-dev] [PATCH v2 1/1] examples/ip_frag: " Sunil Kumar Kori
@ 2019-07-25 7:54 ` Ananyev, Konstantin
2019-07-25 8:24 ` [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag Sunil Kumar Kori
1 sibling, 0 replies; 7+ messages in thread
From: Ananyev, Konstantin @ 2019-07-25 7:54 UTC (permalink / raw)
To: Sunil Kumar Kori; +Cc: dev
> -----Original Message-----
> From: Sunil Kumar Kori [mailto:skori@marvell.com]
> Sent: Thursday, July 25, 2019 6:59 AM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; Sunil Kumar Kori <skori@marvell.com>
> Subject: [PATCH v2 1/1] examples/ip_frag: fix DEV_TX_OFFLOAD_MBUF_FAST_FREE flag
>
> Application uses different pool to allocate direct and indirect
> mbufs which are further spliced together to consturct a fragmented
> packet and same is transmitted over the port which is configured
> with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments
> must belong to the same pool. But constructed packet violates
> the conditions.
>
> So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
> configuration.
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> v2:
> - Subject is corrected.
>
> examples/ip_fragmentation/main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
> index 03be0c1..324d607 100644
> --- a/examples/ip_fragmentation/main.c
> +++ b/examples/ip_fragmentation/main.c
> @@ -939,9 +939,6 @@ struct rte_lpm6_config lpm6_config = {
> n_tx_queue = nb_lcores;
> if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
> n_tx_queue = MAX_TX_QUEUE_PER_PORT;
> - if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
> - local_port_conf.txmode.offloads |=
> - DEV_TX_OFFLOAD_MBUF_FAST_FREE;
> ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue,
> &local_port_conf);
> if (ret < 0) {
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag
2019-07-25 5:58 ` [dpdk-dev] [PATCH v2 1/1] examples/ip_frag: " Sunil Kumar Kori
2019-07-25 7:54 ` Ananyev, Konstantin
@ 2019-07-25 8:24 ` Sunil Kumar Kori
2019-07-25 8:28 ` Jerin Jacob Kollanukkaran
2019-07-25 10:49 ` Ananyev, Konstantin
1 sibling, 2 replies; 7+ messages in thread
From: Sunil Kumar Kori @ 2019-07-25 8:24 UTC (permalink / raw)
To: Konstantin Ananyev; +Cc: dev, stable, Sunil Kumar Kori
Application uses different pool to allocate direct and indirect
mbufs which are further spliced together to consturct a fragmented
packet and same is transmitted over the port which is configured
with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments
must belong to the same pool. But constructed packet violates
the conditions.
So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
configuration.
Fixes: fdb9eff67f0c ("examples/ip_fragmentation: convert to new offloads API")
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
v3:
- Add Fixes tag
v2:
- Subject is corrected.
examples/ip_fragmentation/main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index 03be0c1..324d607 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -939,9 +939,6 @@ struct rte_lpm6_config lpm6_config = {
n_tx_queue = nb_lcores;
if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
n_tx_queue = MAX_TX_QUEUE_PER_PORT;
- if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
- local_port_conf.txmode.offloads |=
- DEV_TX_OFFLOAD_MBUF_FAST_FREE;
ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue,
&local_port_conf);
if (ret < 0) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag
2019-07-25 8:24 ` [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag Sunil Kumar Kori
@ 2019-07-25 8:28 ` Jerin Jacob Kollanukkaran
2019-07-25 10:49 ` Ananyev, Konstantin
1 sibling, 0 replies; 7+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-07-25 8:28 UTC (permalink / raw)
To: Sunil Kumar Kori, Konstantin Ananyev; +Cc: dev, stable, Sunil Kumar Kori
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Sunil Kumar Kori
> Sent: Thursday, July 25, 2019 1:54 PM
> To: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Sunil Kumar Kori <skori@marvell.com>
> Subject: [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload
> flag
>
> Application uses different pool to allocate direct and indirect mbufs which are
> further spliced together to consturct a fragmented packet and same is
> transmitted over the port which is configured with
> DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments must belong
> to the same pool. But constructed packet violates the conditions.
>
> So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
> configuration.
>
> Fixes: fdb9eff67f0c ("examples/ip_fragmentation: convert to new offloads
> API")
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag
2019-07-25 8:24 ` [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag Sunil Kumar Kori
2019-07-25 8:28 ` Jerin Jacob Kollanukkaran
@ 2019-07-25 10:49 ` Ananyev, Konstantin
2019-07-29 21:46 ` Thomas Monjalon
1 sibling, 1 reply; 7+ messages in thread
From: Ananyev, Konstantin @ 2019-07-25 10:49 UTC (permalink / raw)
To: Sunil Kumar Kori; +Cc: dev, stable
> -----Original Message-----
> From: Sunil Kumar Kori [mailto:skori@marvell.com]
> Sent: Thursday, July 25, 2019 9:24 AM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Sunil Kumar Kori <skori@marvell.com>
> Subject: [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag
>
> Application uses different pool to allocate direct and indirect
> mbufs which are further spliced together to consturct a fragmented
> packet and same is transmitted over the port which is configured
> with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments
> must belong to the same pool. But constructed packet violates
> the conditions.
>
> So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
> configuration.
>
> Fixes: fdb9eff67f0c ("examples/ip_fragmentation: convert to new offloads API")
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> v3:
> - Add Fixes tag
> v2:
> - Subject is corrected.
>
> examples/ip_fragmentation/main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
> index 03be0c1..324d607 100644
> --- a/examples/ip_fragmentation/main.c
> +++ b/examples/ip_fragmentation/main.c
> @@ -939,9 +939,6 @@ struct rte_lpm6_config lpm6_config = {
> n_tx_queue = nb_lcores;
> if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
> n_tx_queue = MAX_TX_QUEUE_PER_PORT;
> - if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
> - local_port_conf.txmode.offloads |=
> - DEV_TX_OFFLOAD_MBUF_FAST_FREE;
> ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue,
> &local_port_conf);
> if (ret < 0) {
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag
2019-07-25 10:49 ` Ananyev, Konstantin
@ 2019-07-29 21:46 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2019-07-29 21:46 UTC (permalink / raw)
To: Sunil Kumar Kori; +Cc: dev, Ananyev, Konstantin, stable
> > Application uses different pool to allocate direct and indirect
> > mbufs which are further spliced together to consturct a fragmented
> > packet and same is transmitted over the port which is configured
> > with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments
> > must belong to the same pool. But constructed packet violates
> > the conditions.
> >
> > So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
> > configuration.
> >
> > Fixes: fdb9eff67f0c ("examples/ip_fragmentation: convert to new offloads API")
> >
> > Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-07-29 21:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-25 5:50 [dpdk-dev] [PATCH] examples/ip_fragmentation: fix DEV_TX_OFFLOAD_MBUF_FAST_FREE flag Sunil Kumar Kori
2019-07-25 5:58 ` [dpdk-dev] [PATCH v2 1/1] examples/ip_frag: " Sunil Kumar Kori
2019-07-25 7:54 ` Ananyev, Konstantin
2019-07-25 8:24 ` [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag Sunil Kumar Kori
2019-07-25 8:28 ` Jerin Jacob Kollanukkaran
2019-07-25 10:49 ` Ananyev, Konstantin
2019-07-29 21:46 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).