From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4ADFA046B for ; Fri, 26 Jul 2019 12:22:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A83EC1C45D; Fri, 26 Jul 2019 12:22:03 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 52A9B1C438 for ; Fri, 26 Jul 2019 12:21:50 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C302630C1325; Fri, 26 Jul 2019 10:21:49 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-235.brq.redhat.com [10.40.204.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id B606A62667; Fri, 26 Jul 2019 10:21:48 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Jakub Grajciar Date: Fri, 26 Jul 2019 12:21:26 +0200 Message-Id: <1564136488-29065-8-git-send-email-david.marchand@redhat.com> In-Reply-To: <1564136488-29065-1-git-send-email-david.marchand@redhat.com> References: <1564046068-21905-1-git-send-email-david.marchand@redhat.com> <1564136488-29065-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 26 Jul 2019 10:21:49 +0000 (UTC) Subject: [dpdk-dev] [PATCH v2 7/9] net/memif: do not count unsent packets as errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" n_err reflects the number of packets that the driver did not manage to send. This is a temporary situation, those packets are not freed and the application can still retry to send them later. Hence, we can't count them as transmit failed. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Signed-off-by: David Marchand --- Changelog since v1: - dropped the n_err counter entirely as nothing reports it --- drivers/net/memif/rte_eth_memif.c | 7 ------- drivers/net/memif/rte_eth_memif.h | 1 - 2 files changed, 8 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 00c9b39..bcda426 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -479,7 +479,6 @@ no_free_slots: } } - mq->n_err += nb_pkts - n_tx_pkts; mq->n_pkts += n_tx_pkts; return n_tx_pkts; } @@ -857,7 +856,6 @@ memif_tx_queue_setup(struct rte_eth_dev *dev, (pmd->role == MEMIF_ROLE_SLAVE) ? MEMIF_RING_S2M : MEMIF_RING_M2S; mq->n_pkts = 0; mq->n_bytes = 0; - mq->n_err = 0; mq->intr_handle.fd = -1; mq->intr_handle.type = RTE_INTR_HANDLE_EXT; dev->data->tx_queues[qid] = mq; @@ -886,7 +884,6 @@ memif_rx_queue_setup(struct rte_eth_dev *dev, mq->type = (pmd->role == MEMIF_ROLE_SLAVE) ? MEMIF_RING_M2S : MEMIF_RING_S2M; mq->n_pkts = 0; mq->n_bytes = 0; - mq->n_err = 0; mq->intr_handle.fd = -1; mq->intr_handle.type = RTE_INTR_HANDLE_EXT; mq->mempool = mb_pool; @@ -938,7 +935,6 @@ memif_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->ibytes = 0; stats->opackets = 0; stats->obytes = 0; - stats->oerrors = 0; tmp = (pmd->role == MEMIF_ROLE_SLAVE) ? pmd->run.num_s2m_rings : pmd->run.num_m2s_rings; @@ -966,7 +962,6 @@ memif_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->q_obytes[i] = mq->n_bytes; stats->opackets += mq->n_pkts; stats->obytes += mq->n_bytes; - stats->oerrors += mq->n_err; } return 0; } @@ -983,14 +978,12 @@ memif_stats_reset(struct rte_eth_dev *dev) dev->data->rx_queues[i]; mq->n_pkts = 0; mq->n_bytes = 0; - mq->n_err = 0; } for (i = 0; i < pmd->run.num_m2s_rings; i++) { mq = (pmd->role == MEMIF_ROLE_SLAVE) ? dev->data->rx_queues[i] : dev->data->tx_queues[i]; mq->n_pkts = 0; mq->n_bytes = 0; - mq->n_err = 0; } } diff --git a/drivers/net/memif/rte_eth_memif.h b/drivers/net/memif/rte_eth_memif.h index 24e8a09..8269212 100644 --- a/drivers/net/memif/rte_eth_memif.h +++ b/drivers/net/memif/rte_eth_memif.h @@ -66,7 +66,6 @@ struct memif_queue { /* rx/tx info */ uint64_t n_pkts; /**< number of rx/tx packets */ uint64_t n_bytes; /**< number of rx/tx bytes */ - uint64_t n_err; /**< number of tx errors */ memif_ring_t *ring; /**< pointer to ring */ -- 1.8.3.1