* [dpdk-dev] [PATCH] examples/tep_term: fix out-of-bounds access
@ 2016-07-05 6:15 Beilei Xing
2016-07-11 14:28 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Beilei Xing @ 2016-07-05 6:15 UTC (permalink / raw)
To: jingjing.wu, michalx.k.jastrzebski; +Cc: dev, Beilei Xing
Coverity reported lots of out-of-bounds in function
vxlan_link, these issues should happen when index
port_id evaluates to 2, cause size of arrays is
2 in structure.
Fix this issue by modifying judgement condition, make
sure port_id is less than 2.
Coverity issue: 107121, 107122, 107123, 107124, 107125
Fixes: 4abe471ed6fc ("examples/tep_term: implement VXLAN processing")
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
examples/tep_termination/vxlan_setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/tep_termination/vxlan_setup.c b/examples/tep_termination/vxlan_setup.c
index 37575c2..8f1f15b 100644
--- a/examples/tep_termination/vxlan_setup.c
+++ b/examples/tep_termination/vxlan_setup.c
@@ -249,7 +249,7 @@ vxlan_link(struct vhost_dev *vdev, struct rte_mbuf *m)
struct rte_eth_tunnel_filter_conf tunnel_filter_conf;
- if (unlikely(portid > VXLAN_N_PORTS)) {
+ if (unlikely(portid >= VXLAN_N_PORTS)) {
RTE_LOG(INFO, VHOST_DATA,
"(%d) WARNING: Not configuring device,"
"as already have %d ports for VXLAN.",
--
2.5.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] examples/tep_term: fix out-of-bounds access
2016-07-05 6:15 [dpdk-dev] [PATCH] examples/tep_term: fix out-of-bounds access Beilei Xing
@ 2016-07-11 14:28 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-07-11 14:28 UTC (permalink / raw)
To: Beilei Xing; +Cc: dev, jingjing.wu, michalx.k.jastrzebski
2016-07-05 14:15, Beilei Xing:
> Coverity reported lots of out-of-bounds in function
> vxlan_link, these issues should happen when index
> port_id evaluates to 2, cause size of arrays is
> 2 in structure.
> Fix this issue by modifying judgement condition, make
> sure port_id is less than 2.
>
> Coverity issue: 107121, 107122, 107123, 107124, 107125
>
> Fixes: 4abe471ed6fc ("examples/tep_term: implement VXLAN processing")
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-11 14:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-05 6:15 [dpdk-dev] [PATCH] examples/tep_term: fix out-of-bounds access Beilei Xing
2016-07-11 14:28 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).