From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E970A10DA for ; Thu, 1 Aug 2019 14:27:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A4EE51C1DB; Thu, 1 Aug 2019 14:27:56 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1F2FE1C1D6; Thu, 1 Aug 2019 14:27:55 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 65B70A3B73; Thu, 1 Aug 2019 12:27:54 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-235.brq.redhat.com [10.40.204.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6866760BEC; Thu, 1 Aug 2019 12:27:52 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: aconole@redhat.com, msantana@redhat.com, stable@dpdk.org Date: Thu, 1 Aug 2019 14:27:45 +0200 Message-Id: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 01 Aug 2019 12:27:54 +0000 (UTC) Subject: [dpdk-dev] [PATCH] test/eal: do not scan PCI devices for memory tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The memory tests currently check that, for normal mode (not legacy mode), there is no memory left behind when exiting. The problem is that if a ethdev port is allocated when scanning pci devices (even if the driver probe fails like when you have a virtio management interface attached to the kernel), on exit, dpdk won't free the associated memory since ethdev never frees the ethdev memzone. Workaround this by disabling pci scan. Fixes: 651cc78f83b5 ("test: fix hugepage file handling in EAL flags autotest") Fixes: 690fd3577e90 ("test/eal: add cases for in-memory and single-file-segments") Cc: stable@dpdk.org Signed-off-by: David Marchand --- app/test/test_eal_flags.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index 5b2c0f5..6aaa4a3 100644 --- a/app/test/test_eal_flags.c +++ b/app/test/test_eal_flags.c @@ -1044,7 +1044,7 @@ test_file_prefix(void) DEFAULT_MEM_SIZE, "--file-prefix=" memtest }; /* primary process with memtest1 and default mem mode */ - const char *argv1[] = {prgname, "-m", + const char *argv1[] = {prgname, "--no-pci", "-m", DEFAULT_MEM_SIZE, "--file-prefix=" memtest1 }; /* primary process with memtest1 and legacy mem mode */ @@ -1058,7 +1058,7 @@ test_file_prefix(void) "--legacy-mem" }; /* primary process with memtest2 and default mem mode */ - const char *argv4[] = {prgname, "-m", + const char *argv4[] = {prgname, "--no-pci", "-m", DEFAULT_MEM_SIZE, "--file-prefix=" memtest2 }; /* primary process with --in-memory mode */ @@ -1075,7 +1075,7 @@ test_file_prefix(void) DEFAULT_MEM_SIZE, "--in-memory", "--file-prefix", prefix }; /* primary process with memtest1 and --single-file-segments mode */ - const char * const argv8[] = {prgname, "-m", + const char * const argv8[] = {prgname, "--no-pci", "-m", DEFAULT_MEM_SIZE, "--single-file-segments", "--file-prefix=" memtest1 }; -- 1.8.3.1