From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 4B27125B3 for ; Wed, 20 Sep 2017 17:48:10 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 20 Sep 2017 08:48:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,421,1500966000"; d="scan'208";a="902254091" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 20 Sep 2017 08:48:08 -0700 To: Shachar Beiser , dev@dpdk.org Cc: Adrien Mazarguil , Nelio Laranjeiro References: <0c4ff3cb5a1608e9c2b5717ea3d31e315bb3a6c8.1505744936.git.shacharbe@mellanox.com> From: Ferruh Yigit Message-ID: <15647cd5-aa4b-cf80-97cc-36303dced36b@intel.com> Date: Wed, 20 Sep 2017 16:48:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <0c4ff3cb5a1608e9c2b5717ea3d31e315bb3a6c8.1505744936.git.shacharbe@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v7] net/mlx5: support upstream rdma-core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2017 15:48:11 -0000 On 9/18/2017 3:49 PM, Shachar Beiser wrote: > This removes the dependency on specific Mellanox OFED libraries by > using the upstream rdma-core and linux upstream community code. > Both rdma-core upstream and Mellanox OFED are Linux user-space packages: > 1. Rdma-core is Linux upstream user-space package.(Generic) > 2. Mellanox OFED is Mellanox's Linux user-space package.(Proprietary) > The difference between the two are the APIs towards the kernel. > > --- > a. Compile with rdma-core commit f11292efd541 ("Merge pull request #202") > b. Tested with linux kernel 4.13-rc4 > c. For performance testing recommended to wait till kernel 4.14 > > Signed-off-by: Shachar Beiser Can you please move sign off above comment (---) > --- > > Rebase on top of series: > http://dpdk.org/dev/patchwork/patch/28804/ > http://dpdk.org/dev/patchwork/patch/28805/ > This patch should be applied on top of : > http://dpdk.org/dev/patchwork/patch/28805/ > > This patch enhances the commit log of the previous patch: > http://dpdk.org/dev/patchwork/patch/28803/ > An update to the release notes will be sent saperately by Shahaf > Shuler. > --- Hi Shachar, I can finally able to compile this via rdma-core v15 (Thanks to Nelio), since I don't have Mellanox OFED 4.2 1- Shared library build fails. mlx5 driver now depends on libmlx5.so, this dependency should be added [1], otherwise giving build error [2]. 2- 32bit build broken, this is because rdma-core 32bit missing. a) Is rdma-core supports 32bit? b) Is mlx5 supports 32bit? 3- I am getting ICC warning from rdma-core header [3], same warning many times. Would you mind disabling that warning for mlx5 [4] ? [1] +++ b/drivers/net/mlx5/Makefile @@ -63,7 +63,7 @@ CFLAGS += -D_DEFAULT_SOURCE CFLAGS += -D_XOPEN_SOURCE=600 CFLAGS += $(WERROR_FLAGS) CFLAGS += -Wno-strict-prototypes -LDLIBS += -libverbs +LDLIBS += -libverbs -lmlx5 [2] ../drivers/net/mlx5/mlx5.c:542: undefined reference to `mlx5dv_query_device' mlx5_rxq.o: In function `rxq_setup': ../drivers/net/mlx5/mlx5_rxq.c:803: undefined reference to `mlx5dv_init_obj' mlx5_txq.o: In function `txq_setup': ../drivers/net/mlx5/mlx5_txq.c:175: undefined reference to `mlx5dv_init_obj' [3] In file included from ../drivers/net/mlx5/mlx5.c(48): /root/development/rdma-core/build/include/infiniband/verbs.h(84): warning #61: integer operation result is out of range static void *__VERBS_ABI_IS_EXTENDED = ((uint8_t *) NULL) - 1; ^ [4] +++ b/drivers/net/mlx5/Makefile @@ -77,6 +77,11 @@ ifeq ($(DEBUG),1 +ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) +# For rdma-core v15 headers +CFLAGS += -wd61 +endif <...>