From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9C56A00E6 for ; Mon, 5 Aug 2019 16:27:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 444A41BE1C; Mon, 5 Aug 2019 16:27:14 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1672A1BDF6; Mon, 5 Aug 2019 16:27:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Aug 2019 07:26:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,350,1559545200"; d="scan'208";a="373096603" Received: from npg-dpdk-zhangxiao.sh.intel.com ([10.67.110.190]) by fmsmga005.fm.intel.com with ESMTP; 05 Aug 2019 07:26:28 -0700 From: Xiao Zhang To: dev@dpdk.org Cc: qiming.yang@intel.com, beilei.xing@intel.com, xiaolong.ye@intel.com, Xiao Zhang , stable@dpdk.org Date: Tue, 6 Aug 2019 07:20:53 +0800 Message-Id: <1565047254-66826-5-git-send-email-xiao.zhang@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1565047254-66826-1-git-send-email-xiao.zhang@intel.com> References: <1564952430-6585-1-git-send-email-xiao.zhang@intel.com> <1565047254-66826-1-git-send-email-xiao.zhang@intel.com> Subject: [dpdk-dev] [PATCH v2 4/5] net/iavf: fix dereference after null check coverity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 343447 Fixes: 319c421f ("net/avf: enable SSE Rx Tx") Cc: stable@dpdk.org Signed-off-by: Xiao Zhang --- drivers/net/iavf/iavf_rxtx_vec_sse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/iavf_rxtx_vec_sse.c index 3d98514..cc71f23 100644 --- a/drivers/net/iavf/iavf_rxtx_vec_sse.c +++ b/drivers/net/iavf/iavf_rxtx_vec_sse.c @@ -521,6 +521,7 @@ iavf_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, i++; if (i == nb_bufs) return nb_bufs; + rxq->pkt_first_seg = rx_pkts[i]; } return i + reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i, &split_flags[i]); -- 2.7.4