DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nicolas Chautru <nicolas.chautru@intel.com>
To: dev@dpdk.org, akhil.goyal@nxp.com
Cc: ferruh.yigit@intel.com, thomas@monjalon.net,
	john.mcnamara@intel.com,
	Nicolas Chautru <nicolas.chautru@intel.com>
Subject: [dpdk-dev] [PATCH v2 1/2] baseband/turbo_sw: remove logically dead code
Date: Tue,  6 Aug 2019 07:08:59 -0700	[thread overview]
Message-ID: <1565100540-60599-2-git-send-email-nicolas.chautru@intel.com> (raw)
In-Reply-To: <1565100540-60599-1-git-send-email-nicolas.chautru@intel.com>

Error handling code cannot logically be reached.
Coverity issue : 344980, 344992

Fixes: c769c711757a ("baseband/turbo_sw: extend for 5G")

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 drivers/baseband/turbo_sw/bbdev_turbo_software.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
index acb63a4..f2fe7a2 100644
--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
@@ -1610,12 +1610,6 @@ struct turbo_sw_queue {
 		}
 		r++;
 	}
-
-	if (mbuf_total_left != 0) {
-		op->status |= 1 << RTE_BBDEV_DATA_ERROR;
-		rte_bbdev_log(ERR,
-				"Mismatch between mbuf length and included Circular buffer sizes");
-	}
 }
 
 static inline void
@@ -1706,12 +1700,6 @@ struct turbo_sw_queue {
 		}
 		r++;
 	}
-
-	if (mbuf_total_left != 0) {
-		op->status |= 1 << RTE_BBDEV_DATA_ERROR;
-		rte_bbdev_log(ERR,
-				"Mismatch between mbuf length and included Circular buffer sizes");
-	}
 }
 
 static inline uint16_t
-- 
1.8.3.1


  reply	other threads:[~2019-08-06 21:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06 14:08 [dpdk-dev] [PATCH v2 0/2] coverity fixes for bbdev Nicolas Chautru
2019-08-06 14:08 ` Nicolas Chautru [this message]
2019-08-06 14:09 ` [dpdk-dev] [PATCH v2 2/2] app/bbdev: fix unchecked return valued Nicolas Chautru
2019-08-06 21:39 ` [dpdk-dev] [PATCH v2 0/2] coverity fixes for bbdev Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1565100540-60599-2-git-send-email-nicolas.chautru@intel.com \
    --to=nicolas.chautru@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).