From: Matan Azrad <matan@mellanox.com>
To: dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO
Date: Tue, 6 Aug 2019 14:56:23 +0000 [thread overview]
Message-ID: <1565103383-23864-2-git-send-email-matan@mellanox.com> (raw)
In-Reply-To: <1565103383-23864-1-git-send-email-matan@mellanox.com>
The API breakage is because the ``tso_segsz`` field was documented for
LRO.
The ``tso_segsz`` field in mbuf indicates the size of each segment in
the LRO packet in Rx path and should be provided by the LRO packet
port.
While the generic LRO packet may aggregate different segments sizes in
one packet, it is impossible to expose this information for each segment
by one field and it doesn't make sense to expose all the segments sizes
in the mbuf.
A new field may be added as union with the above field to expose the
number of segments aggregated in the LRO packet.
Signed-off-by: Matan Azrad <matan@mellanox.com>
---
doc/guides/rel_notes/deprecation.rst | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index c0cd9bc..e826b69 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -45,6 +45,10 @@ Deprecation Notices
- ``eal_parse_pci_DomBDF`` replaced by ``rte_pci_addr_parse``
- ``rte_eal_compare_pci_addr`` replaced by ``rte_pci_addr_cmp``
+* mbuf: Remove ``tso_segsz`` mbuf field providing for LRO support. Use union
+ block for the field memory to be shared with a new field ``lro_segs_n``
+ indicates the number of segments aggregated in the LRO packet.
+
* dpaa2: removal of ``rte_dpaa2_memsegs`` structure which has been replaced
by a pa-va search library. This structure was earlier being used for holding
memory segments used by dpaa2 driver for faster pa->va translation. This
--
1.8.3.1
next prev parent reply other threads:[~2019-08-06 14:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 14:56 [dpdk-dev] [PATCH 1/2] doc: announce ethdev ABI change for LRO fields Matan Azrad
2019-08-06 14:56 ` Matan Azrad [this message]
2019-08-06 15:58 ` [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO Ananyev, Konstantin
2019-08-06 18:50 ` Matan Azrad
2019-08-07 10:17 ` Ananyev, Konstantin
2019-08-07 12:35 ` Matan Azrad
2019-08-07 14:18 ` Ananyev, Konstantin
2019-08-08 10:16 ` Matan Azrad
2019-08-08 10:48 ` Ananyev, Konstantin
2019-08-08 11:16 ` Matan Azrad
2019-08-08 16:26 ` Ananyev, Konstantin
2019-08-06 18:17 ` Andrew Rybchenko
2019-08-10 21:31 ` Thomas Monjalon
2020-05-24 23:41 ` Thomas Monjalon
2020-06-02 6:49 ` Matan Azrad
2020-07-27 8:00 ` Olivier Matz
2020-07-27 8:41 ` Matan Azrad
2020-07-27 9:07 ` Olivier Matz
2023-06-12 16:38 ` Stephen Hemminger
2019-08-06 15:27 ` [dpdk-dev] [PATCH 1/2] doc: announce ethdev ABI change for LRO fields Andrew Rybchenko
2019-08-10 21:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565103383-23864-2-git-send-email-matan@mellanox.com \
--to=matan@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).