From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 173EE37B2 for ; Mon, 22 Aug 2016 12:35:04 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id q128so114562899wma.1 for ; Mon, 22 Aug 2016 03:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=zbmaYfxJ78IfGWhbnKcYuxwWIBs/Uwu+CMHAh3AHRMs=; b=StCLo7xpmMgRvmtSCC4QK6QhH6tMd/Ub5U2jfxmIwVQTs/W3QKRK67OliaQEsSrWFo ePznMNuntC8nfbS70mvleBvfeTE7H9+oiVJexzrscMO7XNrdfcVxvX566IOWWjNw677F 6BV7cYf3gyDrirSlq5j1MqIQTF2zSELJLlKLQkrGhTA5ezUUpQceanSVF/tDXMRug7tQ 7pZU+4a+NGEP0kBDnQ4icy7INqoOxrwYQR4Gi1g3KdmVF6ZroQvta8FplgqlzIxSckrV LL5GdTEFf2dROvWcXDnS/bMiauvSFPtOxsdo+N2KBaFh7Celik8l5SOO1GT+9d515voK xeRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=zbmaYfxJ78IfGWhbnKcYuxwWIBs/Uwu+CMHAh3AHRMs=; b=WfNKvDghHaDDjyy8li3rYNqFQyKFPXU5ug/BNTspUvX+Osq8hlRhC/J+0ymVmCy9mn gIzJWclFamHYXc/+H1kd8fMdqEwGoEAifcBuzGRE4h0y1EnFHg9jCBPMxTio+b81Bq1s L4eBbS3o2E1BV017l7yviA2tqcW9pnDf+ponUTAprTLVgu1vE63SNLQNfM8aCnb/9aPK 2WyBSQ4NEXZTYfjGgXJHV4EiwlD3Pcp6UAphN3uix/kGmZ36rOg5/AuYh0oo6wFLo5Rv FKcKPTbHEY/s8ToCMOfyI0bhxCHMiqCI+VtDSklwQV1RBhceFAMEm0Yk6snZwj/OuGXs 326A== X-Gm-Message-State: AEkoouvwOe4A5Dk6HN/80b8i2TAKD2yiXiioUHREiqIUlnI30gsjYCxL4v0ILAiRz96GTmsd X-Received: by 10.28.12.133 with SMTP id 127mr13961624wmm.119.1471862103685; Mon, 22 Aug 2016 03:35:03 -0700 (PDT) Received: from xps13.localnet (171.17.90.79.rev.sfr.net. [79.90.17.171]) by smtp.gmail.com with ESMTPSA id p71sm20545539wmf.9.2016.08.22.03.35.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Aug 2016 03:35:02 -0700 (PDT) From: Thomas Monjalon To: Maxime Coquelin , Zhihong Wang , yuanhan.liu@linux.intel.com Cc: dev@dpdk.org Date: Mon, 22 Aug 2016 12:35:01 +0200 Message-ID: <1565135.2L3BcyTl7O@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2a5320b9-c9dd-f7e3-e659-7d14cd1e5620@redhat.com> References: <1471319402-112998-1-git-send-email-zhihong.wang@intel.com> <2a5320b9-c9dd-f7e3-e659-7d14cd1e5620@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2016 10:35:04 -0000 2016-08-22 12:01, Maxime Coquelin: > I forgot to add that before this series, I think we should first fix the windows bug. > Else we will need a dedicated fix for the stable branch. This is a funny situation :) If Zhihong had reworked the code without mentioning it is fixing a scenario with Windows guests, maybe that nobody would have notice ;) That's probably why it is not written in v2/v3. But thanks to the v1, we all know it: "It also fixes the issue working with Windows VMs." So yes, it would be a lot better to find the root cause and try to have a minimal fix for 16.07, then rework the code for performance in 16.11. I think we must avoid silent fixes, and even more, avoid writing specific fixes for stable branches without validating them in the master branch and its large users base. Thanks for your good works guys, DPDK vhost is improving very well.