DPDK patches and discussions
 help / color / mirror / Atom feed
From: Congwen Zhang <zhang.congwen@zte.com.cn>
To: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com
Cc: dev@dpdk.org, Congwen Zhang <zhang.congwen@zte.com.cn>
Subject: [dpdk-dev] [PATCH] net/ixgbe: fix offset value check
Date: Wed, 7 Aug 2019 14:43:19 +0800	[thread overview]
Message-ID: <1565160199-16087-1-git-send-email-zhang.congwen@zte.com.cn> (raw)

The "and" condition offset == 0 && offset == NVM_INVALID_PTR
 can never be true.

Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
---
 drivers/net/ixgbe/base/ixgbe_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c
index fb50719..e2ffbe6 100644
--- a/drivers/net/ixgbe/base/ixgbe_common.c
+++ b/drivers/net/ixgbe/base/ixgbe_common.c
@@ -5040,7 +5040,7 @@ void ixgbe_get_oem_prod_version(struct ixgbe_hw *hw,
 	hw->eeprom.ops.read(hw, NVM_OEM_PROD_VER_PTR, &offset);
 
 	/* Return is offset to OEM Product Version block is invalid */
-	if (offset == 0x0 && offset == NVM_INVALID_PTR)
+	if ((offset == 0x0) || (offset == NVM_INVALID_PTR))
 		return;
 
 	/* Read product version block */
-- 
1.8.3.1


             reply	other threads:[~2019-08-07  7:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07  6:43 Congwen Zhang [this message]
2019-08-07  8:33 ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1565160199-16087-1-git-send-email-zhang.congwen@zte.com.cn \
    --to=zhang.congwen@zte.com.cn \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).