From: Jim Harris <james.r.harris@intel.com>
To: dev@dpdk.org, anatoly.burakov@intel.com
Subject: [dpdk-dev] [PATCH v2 1/2] timer: use rte_mp_msg to pass TSC hz to secondary procs
Date: Fri, 16 Aug 2019 05:02:30 -0700 [thread overview]
Message-ID: <156595695082.7484.13482698229756801845.stgit@jrharri1-skx> (raw)
rte_eal_init() is much faster in secondary processes since
hugepages don't need to be zeroed. But there's still
non-trivial delays in the timer subsystem initialization
due to the 100ms sleep used to calculate TSC hz. So use
the rte_mp_msg framework to allow secondary processes
to get the TSC hz from the primary process.
This cuts rte_eal_init() execution time in a secondary
process from 165ms to 66ms in my test program.
Signed-off-by: Jim Harris <james.r.harris@intel.com>
---
lib/librte_eal/common/eal_common_timer.c | 70 +++++++++++++++++++++++++++++-
1 file changed, 68 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_timer.c b/lib/librte_eal/common/eal_common_timer.c
index 145543de7..2b6828707 100644
--- a/lib/librte_eal/common/eal_common_timer.c
+++ b/lib/librte_eal/common/eal_common_timer.c
@@ -15,9 +15,16 @@
#include <rte_log.h>
#include <rte_cycles.h>
#include <rte_pause.h>
+#include <rte_eal.h>
#include "eal_private.h"
+#define EAL_TIMER_MP "eal_timer_mp_sync"
+
+struct timer_mp_param {
+ uint64_t tsc;
+};
+
/* The frequency of the RDTSC timer resolution */
static uint64_t eal_tsc_resolution_hz;
@@ -74,8 +81,8 @@ estimate_tsc_freq(void)
return RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ);
}
-void
-set_tsc_freq(void)
+static void
+set_tsc_freq_primary(void)
{
uint64_t freq;
@@ -89,6 +96,65 @@ set_tsc_freq(void)
eal_tsc_resolution_hz = freq;
}
+static void
+set_tsc_freq_secondary(void)
+{
+ struct rte_mp_msg mp_req = {0};;
+ struct rte_mp_reply mp_reply = {0};
+ struct timer_mp_param *r;
+ struct timespec ts = {.tv_sec = 1, .tv_nsec = 0};
+
+ strcpy(mp_req.name, EAL_TIMER_MP);
+ if (rte_mp_request_sync(&mp_req, &mp_reply, &ts) || mp_reply.nb_received != 1) {
+ /* We weren't able to get the tsc hz from the primary process. So we will
+ * just calculate it here in the secondary process instead.
+ */
+ set_tsc_freq_primary();
+ free(mp_reply.msgs);
+ return;
+ }
+
+ r = (struct timer_mp_param *)mp_reply.msgs[0].param;
+ eal_tsc_resolution_hz = r->tsc;
+ free(mp_reply.msgs);
+}
+
+static int
+timer_mp_primary(__attribute__((unused)) const struct rte_mp_msg *msg, const void *peer)
+{
+ struct rte_mp_msg reply;
+ struct timer_mp_param *r = (struct timer_mp_param *)reply.param;
+
+ memset(&reply, 0, sizeof(reply));
+ r->tsc = eal_tsc_resolution_hz;
+ strcpy(reply.name, EAL_TIMER_MP);
+ reply.len_param = sizeof(*r);
+
+ return rte_mp_reply(&reply, peer);
+}
+
+void
+set_tsc_freq(void)
+{
+ int rc;
+
+ /* We use a 100ms timer to calculate the TSC hz. We can save this 100ms in
+ * secondary processes, by getting the TSC hz from the primary process.
+ * So register an mp_action callback in the primary process, which secondary
+ * processes will use to get the TSC hz.
+ */
+ if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
+ set_tsc_freq_primary();
+ rc = rte_mp_action_register(EAL_TIMER_MP, timer_mp_primary);
+ if (rc) {
+ RTE_LOG(WARNING, EAL, "Could not register mp_action - secondary "
+ " processes will calculate TSC independently.\n");
+ }
+ } else {
+ set_tsc_freq_secondary();
+ }
+}
+
void rte_delay_us_callback_register(void (*userfunc)(unsigned int))
{
rte_delay_us = userfunc;
next reply other threads:[~2019-08-16 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 12:02 Jim Harris [this message]
2019-08-16 12:02 ` [dpdk-dev] [PATCH v2 2/2] timer: don't check tsc flags in secondary processes Jim Harris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156595695082.7484.13482698229756801845.stgit@jrharri1-skx \
--to=james.r.harris@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).