From: Arnon Warshavsky <arnon@qwilt.com>
To: dev@dpdk.org
Cc: arnonw@qwilt.com, john.mcnamara@intel.com,
Arnon Warshavsky <arnon@qwilt.com>
Subject: [dpdk-dev] [PATCH] eal: unmap undesired address upon config reattach failure
Date: Sun, 18 Aug 2019 09:47:34 +0300 [thread overview]
Message-ID: <1566110854-2669-1-git-send-email-arnon@qwilt.com> (raw)
Have rte_eal_config_reattach clean up the mapped address
which is a valid address but not the one intended.
Coverity issue: 343439
Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
---
lib/librte_eal/linux/eal/eal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
index 946222c..fac69b9 100644
--- a/lib/librte_eal/linux/eal/eal.c
+++ b/lib/librte_eal/linux/eal/eal.c
@@ -438,6 +438,7 @@ enum rte_iova_mode
RTE_LOG(ERR, EAL, "Cannot mmap memory for rte_config at [%p], got [%p]"
" - please use '--base-virtaddr' option\n",
rte_mem_cfg_addr, mem_config);
+ munmap(mem_config, sizeof(struct rte_mem_config));
return -1;
}
RTE_LOG(ERR, EAL, "Cannot mmap memory for rte_config! error %i (%s)\n",
--
1.8.3.1
next reply other threads:[~2019-08-18 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 6:47 Arnon Warshavsky [this message]
2019-08-19 8:27 ` David Marchand
2019-08-19 13:57 ` [dpdk-dev] [PATCH v2] " Arnon Warshavsky
2019-08-19 14:48 ` Burakov, Anatoly
2019-08-19 15:29 ` David Marchand
2019-10-15 18:39 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566110854-2669-1-git-send-email-arnon@qwilt.com \
--to=arnon@qwilt.com \
--cc=arnonw@qwilt.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).