From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 37E492D13 for ; Thu, 11 Jan 2018 18:54:52 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BF6A720CE2; Thu, 11 Jan 2018 12:54:51 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 11 Jan 2018 12:54:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=k4ZPQ0V8kZTZT4w+whQgKaK38h 5mPrmk5YTkR9ofXmk=; b=COrZUlEH5Yrp8flUSydHlS84duegbt61kD6RDSLDTw U49SLXXrafwmFoNayWKeI9/74Vog8tTwNF5tXoy0bZ3fOUR32HTAAAa7hk2QvyhX qQPuzrlpP39AiMPZvARq3ZMKC/pzobHAt7E8BpGLv7phO26HOA1SPhsEOI7cODLj w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=k4ZPQ0 V8kZTZT4w+whQgKaK38h5mPrmk5YTkR9ofXmk=; b=encA5rNKaksocOanT57dCa lyKY927CBaIkO6XzGgwXAeo9eYx60EVPTPaCRWcjdxnCTgD/DF1MqnnvMzHyBNCZ lLouXF8mBc+h18fDSesHAwF4OaO9+JRDbs6O/cZm5X3rOKqPyjDd0U2SRWvz9/nZ 5Zu2S36W9unTDXN1/6rqkrfYLRdisAeF4rOLPQEPUtYTd3qwRZyqMsc2wScBTwmz iD8iYrYSUyygcB44d6RHQpNOdXblgc2F5enfxAjCkI2iNzWKhWQpdkipOx7FI7ia wA8BSNSUT8uV9TwkURXcmXRXuLujnVIVE2QaNka88o8H4by+Vj6CCeba7LLMRXaw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 674D87E300; Thu, 11 Jan 2018 12:54:51 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Hemant Agrawal Date: Thu, 11 Jan 2018 18:54:23 +0100 Message-ID: <1566328.PjHp2kMIxd@xps> In-Reply-To: <1b245a10-1af9-ebca-021c-63680f4e1cc6@nxp.com> References: <20171219000519.53666-1-ferruh.yigit@intel.com> <1b245a10-1af9-ebca-021c-63680f4e1cc6@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] kni: convert license headers to SPDX tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 17:54:52 -0000 10/01/2018 07:46, Hemant Agrawal: > On 1/9/2018 9:00 PM, Ferruh Yigit wrote: > > On 1/9/2018 3:24 PM, Thomas Monjalon wrote: > >> 09/01/2018 16:12, Ferruh Yigit: > >>> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h > >>> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h > >>> +/* SPDX-License-Identifier: (BSD-3-Clause OR LGPL-2.1) */ > >>> +/* > >>> + * Copyright(c) 2007-2014 Intel Corporation. > >>> */ > >> > >>> --- a/lib/librte_eal/linuxapp/kni/kni_net.c > >>> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c > >>> +// SPDX-License-Identifier: GPL-2.0 > >>> +/* > >>> + * Copyright(c) 2010-2014 Intel Corporation. > >>> */ > >> > >> Why these empty lines between SPDX and Copyright? > > > > For kernel module files I followed Linux style, as "//" comments in .c files. > > I don't have strong opinion about this... > > > > > I think it is just fine to use the Linux style for kernel module based > code. > Acked-by: Hemant Agrawal Applied, thanks