From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42C76A0A02; Fri, 26 Mar 2021 10:30:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 202C540685; Fri, 26 Mar 2021 10:30:41 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id C37214067B for ; Fri, 26 Mar 2021 10:30:39 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 4389C5C0185; Fri, 26 Mar 2021 05:30:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 26 Mar 2021 05:30:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= dRI7omAs+VKb3I+jxqr9V5KdlQr2xSKf23qivj0B5yw=; b=4DZX3qtg5X68xYMu FoNsmk2WXZzEkUnwEw2kCzWdoRRe+nSVHkF+0WQcvHCuIbFp3N2q1VRLVhyyDTsI OOHDPimBd9FEr+CDi2sIrynucKfk/m4phhMSMYVS1W017hQhgJH8Hk9CBMuwaXqL LxmpyBitfftJHVCCM9cFUz1QNV6GFAkEXpLPH4tkrPy/qKal3xkYrCQpDMo7UGsS W3N31JYLExFYuAmuk3RE4dOLeZmzeXk6aAdKBiR3gsyLT5khjxFlwhhInQSC7yfD eifbEvmUQXsxvB/0oHbtRlC9JkG1V0dOfyzp0oMpPv0t6XER2ONxIOV2hJbpB6IR h+qSkg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=dRI7omAs+VKb3I+jxqr9V5KdlQr2xSKf23qivj0B5 yw=; b=LtvkvcOKkWu4CTS2YX9qJSPirbUvYUDmvE33dBGMnbhP0wOkD10/76iRB NQzaXTg/tpkdnVatwbAl/T+dO7aIl3g+8jEFpkwEorAzblUHSmrQAodZJuyoR0Jr 0NM5nvalEYF4l19IMONBUk6cR0IeCW6hBfP8oKB5Jj6DmXLjeE8vNnrsXe/dc80N S4du/U0pJcRb6Hb62RQsLW8t5uiUfqE3PKozip3IP76gnumjpeVGDw6X5Bh+/KeJ m3stFOF4FFnGT6zTAf4OVPrKtZEYX60dlxRWLDqZZykn8ePEKvaXWP9rxdqtd5iT Pc/G6VKs9aeNnbCvVjdlSdiaROyUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehvddgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeekuddrudekhedrudeihedrudektdenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (180.165.185.81.rev.sfr.net [81.185.165.180]) by mail.messagingengine.com (Postfix) with ESMTPA id 5C6D31080066; Fri, 26 Mar 2021 05:30:37 -0400 (EDT) From: Thomas Monjalon To: Gabriel Ganne Cc: Bruce Richardson , dev@dpdk.org, thierry.herbelot@6wind.com, dev@dpdk.org Date: Fri, 26 Mar 2021 10:30:33 +0100 Message-ID: <15666790.eF8HPZDLRE@thomas> In-Reply-To: <20210326082223.1398-1-gabriel.ganne@6wind.com> References: <20210326082223.1398-1-gabriel.ganne@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/03/2021 09:22, Gabriel Ganne: > libpcap is already found and registered as a dependency by meson, and > the dependency is already correctly used in librte_port. This line is > just unnecessary. > > It also has the side effect of messing with the meson link line: dpdk > link will be declared twice: manually and then through pkg-config. If > you configure meson to prefer static linking over dynamic, this will > cause the build to fail on librte_port, since the pcap deps are not yet > seen by the linker. > > Signed-off-by: Gabriel Ganne When sending a new revision of a patch, please add a changelog below "---" and use --in-reply-to for threading, thanks. > --- > config/meson.build | 1 - > 1 file changed, 1 deletion(-)