From: Jim Harris <james.r.harris@intel.com>
To: dev@dpdk.org, bruce.richardson@intel.com, anatoly.burakov@intel.com
Subject: [dpdk-dev] [PATCH v5] eal: use memzone to share tsc hz with secondary processes
Date: Mon, 26 Aug 2019 06:44:46 -0700 [thread overview]
Message-ID: <156682708634.28714.543470193614987025.stgit@jrharri1-skx> (raw)
In-Reply-To: <156646334762.14099.13593080473257757748.stgit@jrharri1-skx>
Ideally, get_tsc_freq_arch() is able to provide the
TSC rate using arch-specific means. When that is not
possible, DPDK reverts to calculating the TSC rate with
a 100ms nanosleep or 1s sleep. The latter occurs more
frequently in VMs which often do not have access to the
data they need from arch-specific means (CPUID leaf 0x15
or MSR 0xCE on x86).
In secondary processes, the extra 100ms is especially
noticeable and consumes the bulk of rte_eal_init()
execution time. To resolve this extra delay, have
the primary process put the TSC rate into a shared
memory region that the secondary process can lookup.
Reduces rte_eal_init() execution time in a secondary
process from 165ms to 66ms on my test system.
Signed-off-by: Jim Harris <james.r.harris@intel.com>
---
lib/librte_eal/common/eal_common_timer.c | 20 ++++++++++++++++++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_timer.c b/lib/librte_eal/common/eal_common_timer.c
index 145543de7..2aeab6462 100644
--- a/lib/librte_eal/common/eal_common_timer.c
+++ b/lib/librte_eal/common/eal_common_timer.c
@@ -15,9 +15,12 @@
#include <rte_log.h>
#include <rte_cycles.h>
#include <rte_pause.h>
+#include <rte_memzone.h>
#include "eal_private.h"
+static const char *MZ_RTE_TSC_FREQ = "rte_tsc_freq";
+
/* The frequency of the RDTSC timer resolution */
static uint64_t eal_tsc_resolution_hz;
@@ -77,9 +80,16 @@ estimate_tsc_freq(void)
void
set_tsc_freq(void)
{
- uint64_t freq;
+ const struct rte_memzone *mz;
+ uint64_t freq = 0;
- freq = get_tsc_freq_arch();
+ if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
+ mz = rte_memzone_lookup(MZ_RTE_TSC_FREQ);
+ if (mz != NULL)
+ freq = *(uint64_t *)mz->addr;
+ }
+ if (!freq)
+ freq = get_tsc_freq_arch();
if (!freq)
freq = get_tsc_freq();
if (!freq)
@@ -87,6 +97,12 @@ set_tsc_freq(void)
RTE_LOG(DEBUG, EAL, "TSC frequency is ~%" PRIu64 " KHz\n", freq / 1000);
eal_tsc_resolution_hz = freq;
+ if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
+ mz = rte_memzone_reserve(MZ_RTE_TSC_FREQ, sizeof(uint64_t),
+ SOCKET_ID_ANY, 0);
+ if (mz != NULL)
+ *(uint64_t *)mz->addr = freq;
+ }
}
void rte_delay_us_callback_register(void (*userfunc)(unsigned int))
next prev parent reply other threads:[~2019-08-26 20:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 8:42 [dpdk-dev] [PATCH v3] timer: use rte_mp_msg to get freq from primary process Jim Harris
2019-08-26 13:39 ` [dpdk-dev] [PATCH v4] eal: use memzone to share tsc hz with secondary processes Jim Harris
2019-08-26 13:44 ` Jim Harris [this message]
2019-08-27 8:14 ` [dpdk-dev] [PATCH v5] " Bruce Richardson
2019-08-27 12:04 ` Burakov, Anatoly
2019-08-27 12:48 ` Bruce Richardson
2019-08-28 9:01 ` Burakov, Anatoly
2019-08-27 14:00 ` Bruce Richardson
2019-08-27 16:16 ` [dpdk-dev] [PATCH v6] eal: add tsc_hz to rte_mem_config Jim Harris
2019-10-07 15:28 ` [dpdk-dev] [PATCH v6 RESEND] " Jim Harris
2019-10-08 8:38 ` Bruce Richardson
2019-10-21 8:23 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156682708634.28714.543470193614987025.stgit@jrharri1-skx \
--to=james.r.harris@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).