DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nitin Katiyar <nitin.katiyar@ericsson.com>
To: <dev@dpdk.org>
Cc: Nitin Katiyar <nitin.katiyar@ericsson.com>
Subject: [dpdk-dev] [PATCH 2/2] eal: DPDK init doesn't fail even if device probe fails.
Date: Wed, 28 Aug 2019 01:00:17 +0530	[thread overview]
Message-ID: <1566934217-23824-2-git-send-email-nitin.katiyar@ericsson.com> (raw)
In-Reply-To: <1566934217-23824-1-git-send-email-nitin.katiyar@ericsson.com>

rte_bus_probe() doesn't return error. As a result rte_eal_init()
doesn't catch this error and thus making dpdk initialization
successful despite probe failing for devices.

This patch returns error if probe fails for any of device.

Signed-off-by: Nitin Katiyar <nitin.katiyar@ericsson.com>
---
 lib/librte_eal/common/eal_common_bus.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c
index baa5b53..1721179 100644
--- a/lib/librte_eal/common/eal_common_bus.c
+++ b/lib/librte_eal/common/eal_common_bus.c
@@ -70,16 +70,20 @@
 		}
 
 		ret = bus->probe();
-		if (ret)
+		if (ret) {
 			RTE_LOG(ERR, EAL, "Bus (%s) probe failed.\n",
 				bus->name);
+			return ret;
+		}
 	}
 
 	if (vbus) {
 		ret = vbus->probe();
-		if (ret)
+		if (ret) {
 			RTE_LOG(ERR, EAL, "Bus (%s) probe failed.\n",
 				vbus->name);
+			return ret;
+		}
 	}
 
 	return 0;
-- 
1.9.1


  reply	other threads:[~2019-08-27 11:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 19:30 [dpdk-dev] [PATCH 1/2] bus/pci: Fail rte_pci_probe if probing all whitelisted devices fail Nitin Katiyar
2019-08-27 19:30 ` Nitin Katiyar [this message]
2019-08-27 13:57   ` [dpdk-dev] [PATCH 2/2] eal: DPDK init doesn't fail even if device probe fails Aaron Conole
2019-08-27 20:12 ` [dpdk-dev] [PATCH 1/2] bus/pci: Fail rte_pci_probe if probing all whitelisted devices fail Stephen Hemminger
2019-08-29  3:47   ` Nitin Katiyar
2019-08-29 15:33     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1566934217-23824-2-git-send-email-nitin.katiyar@ericsson.com \
    --to=nitin.katiyar@ericsson.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).