DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Kovacevic, Marko" <marko.kovacevic@intel.com>
Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com
Subject: Re: [dpdk-dev] [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti-buffer lib v0.49
Date: Sat, 31 Mar 2018 15:40:02 +0200	[thread overview]
Message-ID: <1567480.ON0PbBP0xs@xps> (raw)
In-Reply-To: <20180327121430.44541-1-marko.kovacevic@intel.com>

27/03/2018 14:14, Kovacevic, Marko:
> From: Marko Kovacevic <marko.kovacevic@intel.com>
> 
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>

No comment at all?
This new version doesn't work with the env variable.
It is probably worth few words.

> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -183,8 +183,6 @@ config () # <directory> <target> <options>
>  		test -z "$ARMV8_CRYPTO_LIB_PATH" || \
>  		sed -ri   's,(PMD_ARMV8_CRYPTO=)n,\1y,' $1/.config
>  		test -z "$AESNI_MULTI_BUFFER_LIB_PATH" || \
> -		sed -ri       's,(PMD_AESNI_MB=)n,\1y,' $1/.config
> -		test -z "$AESNI_MULTI_BUFFER_LIB_PATH" || \
>  		sed -ri      's,(PMD_AESNI_GCM=)n,\1y,' $1/.config

The purpose of test-build.sh is to test the build :)
So you need to provide a way to enable this PMD if the dependency
is available. Look at DPDK_DEP_SSL as an example.

  parent reply	other threads:[~2018-04-02 14:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 12:14 Kovacevic, Marko
2018-03-27 12:14 ` [dpdk-dev] [PATCH v1 2/2] crypto/aesni_gcm: support IPsec Multi-buffer " Kovacevic, Marko
2018-03-30 15:16   ` De Lara Guarch, Pablo
2018-03-30 15:41     ` De Lara Guarch, Pablo
2018-03-30 15:16 ` [dpdk-dev] [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti-buffer " De Lara Guarch, Pablo
2018-03-30 15:40   ` De Lara Guarch, Pablo
2018-03-31 13:40 ` Thomas Monjalon [this message]
2018-04-03 13:29 ` [dpdk-dev] [PATCH v2 " Kovacevic, Marko
2018-04-03 13:30   ` [dpdk-dev] [PATCH v2 2/2] crypto/aesni_gcm: support IPsec Multi-buffer " Kovacevic, Marko
2018-04-03 15:22   ` [dpdk-dev] [PATCH v3 1/2] crypto/aesni_mb: support IPsec MUlti-buffer " Kovacevic, Marko
2018-04-03 15:22     ` [dpdk-dev] [PATCH v3 2/2] crypto/aesni_gcm: support IPsec Multi-buffer " Kovacevic, Marko
2018-04-04 12:33       ` De Lara Guarch, Pablo
2018-04-04 12:32     ` [dpdk-dev] [PATCH v3 1/2] crypto/aesni_mb: support IPsec MUlti-buffer " De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1567480.ON0PbBP0xs@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=marko.kovacevic@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).