From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 5A7101322C for ; Mon, 2 Apr 2018 16:52:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 05CBD211BB; Mon, 2 Apr 2018 10:52:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 02 Apr 2018 10:52:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=JD6iQjMTjH8GHO6DGafiANl92o q7/3wQlXBd1AGwnFY=; b=k8WflvaTVz5E05SxV7e4nw8kBSdj5/lq0AzZw3emiG GzVifar0C/UNYPvD3l/PVn+X/EhpwTndOPWk0dig/de0pGS5gZB2BJ5dAsiIY9ZM gR0OcQFtE00HpKN2p4iM+FlOi5iDsRFLuQzsbP9w0q89poVDA04IAzvHBjopn+Bk c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=JD6iQj MTjH8GHO6DGafiANl92oq7/3wQlXBd1AGwnFY=; b=QdxX08u4jCu4tGo8g3og5O aRdAn5ODI0C6TVs7c3XxAPv1EL1pRewnRO4mOGLCts0MEjKdCwQkkJ72uUvQNDan TflV3Ifv/a6VJMjHpJR6iZPyUKKC/SVinjsp4bgCn04141vteyN5vVYoXN+JY+Xj EO/8crzOr8vI7Ud4obUi6cBsYRXmfLqnSydJF3IUBB18ARxYG0Ka1L0C9/CIbRIW dAMh2Kavh+2xEqR5hAMnH+k0qPUPLC6OF3v+5yivEizh+eeZJMlCWX52EPg192va 0JcS3JQtbAjEkrkmqJvXHpOYe/6B5VXp9Lbi7gDAX0ZYWshEitKcxMPT3OzgJTlw == X-ME-Sender: Received: from xps.localnet (84.19.136.77.rev.sfr.net [77.136.19.84]) by mail.messagingengine.com (Postfix) with ESMTPA id 02EC610262; Mon, 2 Apr 2018 10:52:09 -0400 (EDT) From: Thomas Monjalon To: "Kovacevic, Marko" Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com Date: Sat, 31 Mar 2018 15:40:02 +0200 Message-ID: <1567480.ON0PbBP0xs@xps> In-Reply-To: <20180327121430.44541-1-marko.kovacevic@intel.com> References: <20180327121430.44541-1-marko.kovacevic@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti-buffer lib v0.49 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 14:52:12 -0000 27/03/2018 14:14, Kovacevic, Marko: > From: Marko Kovacevic > > Signed-off-by: Marko Kovacevic No comment at all? This new version doesn't work with the env variable. It is probably worth few words. > --- a/devtools/test-build.sh > +++ b/devtools/test-build.sh > @@ -183,8 +183,6 @@ config () # > test -z "$ARMV8_CRYPTO_LIB_PATH" || \ > sed -ri 's,(PMD_ARMV8_CRYPTO=)n,\1y,' $1/.config > test -z "$AESNI_MULTI_BUFFER_LIB_PATH" || \ > - sed -ri 's,(PMD_AESNI_MB=)n,\1y,' $1/.config > - test -z "$AESNI_MULTI_BUFFER_LIB_PATH" || \ > sed -ri 's,(PMD_AESNI_GCM=)n,\1y,' $1/.config The purpose of test-build.sh is to test the build :) So you need to provide a way to enable this PMD if the dependency is available. Look at DPDK_DEP_SSL as an example.