* [dpdk-dev] [PATCH] net/sfc: fix missing notification on link status change
@ 2019-09-06 10:49 Andrew Rybchenko
2019-09-13 17:52 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Rybchenko @ 2019-09-06 10:49 UTC (permalink / raw)
To: dev; +Cc: stable
rte_eth_linkstatus_set() returns 0 when link up status changes.
Fixes: 4abe903e5078 ("net/sfc: use link status helper functions")
Cc: stable@dpdk.org
Reported-by: Shuki Katzenelson <shuki@lightbitslabs.com>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/sfc_ev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_ev.c b/drivers/net/sfc/sfc_ev.c
index 0f216da5d9..6a58a2d975 100644
--- a/drivers/net/sfc/sfc_ev.c
+++ b/drivers/net/sfc/sfc_ev.c
@@ -420,7 +420,7 @@ sfc_ev_link_change(void *arg, efx_link_mode_t link_mode)
struct rte_eth_link new_link;
sfc_port_link_mode_to_info(link_mode, &new_link);
- if (rte_eth_linkstatus_set(sa->eth_dev, &new_link))
+ if (rte_eth_linkstatus_set(sa->eth_dev, &new_link) == 0)
evq->sa->port.lsc_seq++;
return B_FALSE;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix missing notification on link status change
2019-09-06 10:49 [dpdk-dev] [PATCH] net/sfc: fix missing notification on link status change Andrew Rybchenko
@ 2019-09-13 17:52 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2019-09-13 17:52 UTC (permalink / raw)
To: Andrew Rybchenko, dev; +Cc: stable
On 9/6/2019 11:49 AM, Andrew Rybchenko wrote:
> rte_eth_linkstatus_set() returns 0 when link up status changes.
>
> Fixes: 4abe903e5078 ("net/sfc: use link status helper functions")
> Cc: stable@dpdk.org
>
> Reported-by: Shuki Katzenelson <shuki@lightbitslabs.com>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-13 17:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06 10:49 [dpdk-dev] [PATCH] net/sfc: fix missing notification on link status change Andrew Rybchenko
2019-09-13 17:52 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).