From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>, Igor Romanov <Igor.Romanov@oktetlabs.ru>
Subject: [dpdk-dev] [PATCH 0/2] ethdev: change xstats reset function return value to int
Date: Fri, 6 Sep 2019 15:34:52 +0100 [thread overview]
Message-ID: <1567780495-14120-1-git-send-email-arybchenko@solarflare.com> (raw)
It is the third patch series to get rid of void returning functions
in ethdev in accordance with deprecation notice [1].
It should be applied on top of the first [2] and the second [3].
It could be applied separately, but few simple conflicts should
be resolved.
Functions which return void are bad since they do not provide explicit
information to the caller if everything is OK or not.
It is especially painful in the case of promiscuous mode since it is
not always supported, there are real cases when it fails to apply and
it affects traffic which is received by the port.
Driver maintainrs are encouraged to review the patch which changes
driver callbacks prototype.
[1] https://patches.dpdk.org/patch/56969/
[2] https://patches.dpdk.org/project/dpdk/list/?series=6222
[3] https://patches.dpdk.org/project/dpdk/list/?series=6264
Igor Romanov (2):
ethdev: change xstats reset function return value to int
ethdev: make stats and xstats reset callbacks return int
app/proc-info/main.c | 10 +++++-
app/test-pmd/config.c | 8 ++++-
app/test/virtual_pmd.c | 4 ++-
doc/guides/rel_notes/deprecation.rst | 1 -
doc/guides/rel_notes/release_19_11.rst | 3 ++
drivers/net/af_packet/rte_eth_af_packet.c | 4 ++-
drivers/net/af_xdp/rte_eth_af_xdp.c | 4 ++-
drivers/net/ark/ark_ethdev.c | 6 ++--
drivers/net/atlantic/atl_ethdev.c | 6 ++--
drivers/net/avp/avp_ethdev.c | 6 ++--
drivers/net/axgbe/axgbe_ethdev.c | 6 ++--
drivers/net/bnxt/bnxt_stats.c | 38 +++++++++++++++++------
drivers/net/bnxt/bnxt_stats.h | 4 +--
drivers/net/bonding/rte_eth_bond_pmd.c | 13 ++++++--
drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++-
drivers/net/dpaa/dpaa_ethdev.c | 4 ++-
drivers/net/dpaa2/dpaa2_ethdev.c | 10 +++---
drivers/net/e1000/em_ethdev.c | 6 ++--
drivers/net/e1000/igb_ethdev.c | 18 +++++++----
drivers/net/enetc/enetc_ethdev.c | 4 ++-
drivers/net/enic/enic.h | 2 +-
drivers/net/enic/enic_ethdev.c | 4 +--
drivers/net/enic/enic_main.c | 11 +++++--
drivers/net/failsafe/failsafe_ops.c | 16 ++++++++--
drivers/net/fm10k/fm10k_ethdev.c | 10 ++++--
drivers/net/hinic/base/hinic_pmd_niccfg.c | 14 ++++++---
drivers/net/hinic/base/hinic_pmd_niccfg.h | 4 +--
drivers/net/hinic/hinic_pmd_ethdev.c | 25 +++++++++++----
drivers/net/i40e/i40e_ethdev.c | 6 ++--
drivers/net/i40e/i40e_ethdev_vf.c | 6 ++--
drivers/net/i40e/i40e_vf_representor.c | 4 +--
drivers/net/iavf/iavf_ethdev.c | 11 ++++---
drivers/net/ice/ice_ethdev.c | 6 ++--
drivers/net/ipn3ke/ipn3ke_representor.c | 14 +++++----
drivers/net/ixgbe/ixgbe_ethdev.c | 18 +++++++----
drivers/net/kni/rte_eth_kni.c | 4 ++-
drivers/net/liquidio/lio_ethdev.c | 23 ++++++++------
drivers/net/memif/rte_eth_memif.c | 4 ++-
drivers/net/mlx4/mlx4.h | 2 +-
drivers/net/mlx4/mlx4_ethdev.c | 7 ++++-
drivers/net/mlx5/mlx5.h | 4 +--
drivers/net/mlx5/mlx5_stats.c | 19 +++++++++---
drivers/net/mvneta/mvneta_ethdev.c | 11 +++++--
drivers/net/mvpp2/mrvl_ethdev.c | 16 +++++++---
drivers/net/netvsc/hn_ethdev.c | 15 ++++++---
drivers/net/netvsc/hn_var.h | 4 +--
drivers/net/netvsc/hn_vf.c | 13 +++++---
drivers/net/nfp/nfp_net.c | 6 ++--
drivers/net/null/rte_eth_null.c | 6 ++--
drivers/net/octeontx/octeontx_ethdev.c | 8 ++---
drivers/net/octeontx2/otx2_ethdev.h | 4 +--
drivers/net/octeontx2/otx2_stats.c | 33 +++++++++++++-------
drivers/net/pcap/rte_eth_pcap.c | 4 ++-
drivers/net/qede/qede_ethdev.c | 8 +++--
drivers/net/ring/rte_eth_ring.c | 4 ++-
drivers/net/sfc/sfc_ethdev.c | 7 +++--
drivers/net/szedata2/rte_eth_szedata2.c | 4 ++-
drivers/net/tap/rte_eth_tap.c | 4 ++-
drivers/net/thunderx/nicvf_ethdev.c | 13 ++++++--
drivers/net/vhost/rte_eth_vhost.c | 8 +++--
drivers/net/virtio/virtio_ethdev.c | 6 ++--
drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++--
lib/librte_ethdev/rte_ethdev.c | 18 ++++++-----
lib/librte_ethdev/rte_ethdev.h | 9 +++++-
lib/librte_ethdev/rte_ethdev_core.h | 4 +--
65 files changed, 408 insertions(+), 176 deletions(-)
--
2.17.1
next reply other threads:[~2019-09-06 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 14:34 Andrew Rybchenko [this message]
2019-09-06 14:34 ` [dpdk-dev] [PATCH 1/2] " Andrew Rybchenko
2019-09-06 14:34 ` [dpdk-dev] [PATCH 2/2] ethdev: make stats and xstats reset callbacks return int Andrew Rybchenko
2019-09-24 11:56 ` Ferruh Yigit
2019-09-24 13:03 ` Andrew Rybchenko
2019-09-24 11:56 ` [dpdk-dev] [PATCH 0/2] ethdev: change xstats reset function return value to int Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567780495-14120-1-git-send-email-arybchenko@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=Igor.Romanov@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).