From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F4CBA2EDB for ; Fri, 6 Sep 2019 16:35:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA0561F3E4; Fri, 6 Sep 2019 16:35:40 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 2815E1F367 for ; Fri, 6 Sep 2019 16:35:40 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 360096C0053; Fri, 6 Sep 2019 14:35:36 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Sep 2019 07:35:33 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Fri, 6 Sep 2019 07:35:32 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x86EZVGU027442; Fri, 6 Sep 2019 15:35:31 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 9D3211613D1; Fri, 6 Sep 2019 15:35:31 +0100 (BST) From: Andrew Rybchenko To: Thomas Monjalon , Ferruh Yigit CC: , Igor Romanov Date: Fri, 6 Sep 2019 15:34:52 +0100 Message-ID: <1567780495-14120-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24892.005 X-TM-AS-Result: No-6.742200-4.000000-10 X-TMASE-MatchedRID: kj6Y84S1kcJpokC3EjW38LmQWToO0X1/oUIbLcCfRuBvn11REP3xnuCS qBCtgN73E0xR9DL8LTVUgpn09r97XrrC27CKHcBx4h8r8l3l4eYGchEhVwJY38CWv3N/XH+WMUC dtsaTPHmayDMlI8umO4b8NSSJFJE+Pdnzj+bMJ9OdVNZaI2n6/1tXgpRlmDcobPfGfHxv+pHy71 Hqi5zuoFeJhXqvy4uMyi1jOsEtxG5+K37CQGCLSTVUc/h8Ki+CVBPjB/Of+FRTHhSneq8wp7QNI jvzOe3L8XVI39JCRnQCc2wLmZy7ABtM6v9NhvjM/1dEgwtQ6NCFUOeR/MPu5pGPHiE2kiT4TSS0 Xlcx51Tik/RwfBzSK4Ay6p60ZV62rpt78afcDNfdB/CxWTRRuwihQpoXbuXFSeyzvdIczoQghTG mPa40YqnOAz81qNQT/fSR5KXv3cQuMexz7qEJlPHGNhh0k7et3nPQowFn+di9yptP09F2z2QP/Y GCn4toD1y8R38S3l1URzkirO0Q1F5h9KQWrq4BvuMTr7CQJJ6eqD9WtJkSIw== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--6.742200-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24892.005 X-MDID: 1567780537-x-18be4dAuC8 Subject: [dpdk-dev] [PATCH 0/2] ethdev: change xstats reset function return value to int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It is the third patch series to get rid of void returning functions in ethdev in accordance with deprecation notice [1]. It should be applied on top of the first [2] and the second [3]. It could be applied separately, but few simple conflicts should be resolved. Functions which return void are bad since they do not provide explicit information to the caller if everything is OK or not. It is especially painful in the case of promiscuous mode since it is not always supported, there are real cases when it fails to apply and it affects traffic which is received by the port. Driver maintainrs are encouraged to review the patch which changes driver callbacks prototype. [1] https://patches.dpdk.org/patch/56969/ [2] https://patches.dpdk.org/project/dpdk/list/?series=6222 [3] https://patches.dpdk.org/project/dpdk/list/?series=6264 Igor Romanov (2): ethdev: change xstats reset function return value to int ethdev: make stats and xstats reset callbacks return int app/proc-info/main.c | 10 +++++- app/test-pmd/config.c | 8 ++++- app/test/virtual_pmd.c | 4 ++- doc/guides/rel_notes/deprecation.rst | 1 - doc/guides/rel_notes/release_19_11.rst | 3 ++ drivers/net/af_packet/rte_eth_af_packet.c | 4 ++- drivers/net/af_xdp/rte_eth_af_xdp.c | 4 ++- drivers/net/ark/ark_ethdev.c | 6 ++-- drivers/net/atlantic/atl_ethdev.c | 6 ++-- drivers/net/avp/avp_ethdev.c | 6 ++-- drivers/net/axgbe/axgbe_ethdev.c | 6 ++-- drivers/net/bnxt/bnxt_stats.c | 38 +++++++++++++++++------ drivers/net/bnxt/bnxt_stats.h | 4 +-- drivers/net/bonding/rte_eth_bond_pmd.c | 13 ++++++-- drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++- drivers/net/dpaa/dpaa_ethdev.c | 4 ++- drivers/net/dpaa2/dpaa2_ethdev.c | 10 +++--- drivers/net/e1000/em_ethdev.c | 6 ++-- drivers/net/e1000/igb_ethdev.c | 18 +++++++---- drivers/net/enetc/enetc_ethdev.c | 4 ++- drivers/net/enic/enic.h | 2 +- drivers/net/enic/enic_ethdev.c | 4 +-- drivers/net/enic/enic_main.c | 11 +++++-- drivers/net/failsafe/failsafe_ops.c | 16 ++++++++-- drivers/net/fm10k/fm10k_ethdev.c | 10 ++++-- drivers/net/hinic/base/hinic_pmd_niccfg.c | 14 ++++++--- drivers/net/hinic/base/hinic_pmd_niccfg.h | 4 +-- drivers/net/hinic/hinic_pmd_ethdev.c | 25 +++++++++++---- drivers/net/i40e/i40e_ethdev.c | 6 ++-- drivers/net/i40e/i40e_ethdev_vf.c | 6 ++-- drivers/net/i40e/i40e_vf_representor.c | 4 +-- drivers/net/iavf/iavf_ethdev.c | 11 ++++--- drivers/net/ice/ice_ethdev.c | 6 ++-- drivers/net/ipn3ke/ipn3ke_representor.c | 14 +++++---- drivers/net/ixgbe/ixgbe_ethdev.c | 18 +++++++---- drivers/net/kni/rte_eth_kni.c | 4 ++- drivers/net/liquidio/lio_ethdev.c | 23 ++++++++------ drivers/net/memif/rte_eth_memif.c | 4 ++- drivers/net/mlx4/mlx4.h | 2 +- drivers/net/mlx4/mlx4_ethdev.c | 7 ++++- drivers/net/mlx5/mlx5.h | 4 +-- drivers/net/mlx5/mlx5_stats.c | 19 +++++++++--- drivers/net/mvneta/mvneta_ethdev.c | 11 +++++-- drivers/net/mvpp2/mrvl_ethdev.c | 16 +++++++--- drivers/net/netvsc/hn_ethdev.c | 15 ++++++--- drivers/net/netvsc/hn_var.h | 4 +-- drivers/net/netvsc/hn_vf.c | 13 +++++--- drivers/net/nfp/nfp_net.c | 6 ++-- drivers/net/null/rte_eth_null.c | 6 ++-- drivers/net/octeontx/octeontx_ethdev.c | 8 ++--- drivers/net/octeontx2/otx2_ethdev.h | 4 +-- drivers/net/octeontx2/otx2_stats.c | 33 +++++++++++++------- drivers/net/pcap/rte_eth_pcap.c | 4 ++- drivers/net/qede/qede_ethdev.c | 8 +++-- drivers/net/ring/rte_eth_ring.c | 4 ++- drivers/net/sfc/sfc_ethdev.c | 7 +++-- drivers/net/szedata2/rte_eth_szedata2.c | 4 ++- drivers/net/tap/rte_eth_tap.c | 4 ++- drivers/net/thunderx/nicvf_ethdev.c | 13 ++++++-- drivers/net/vhost/rte_eth_vhost.c | 8 +++-- drivers/net/virtio/virtio_ethdev.c | 6 ++-- drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++-- lib/librte_ethdev/rte_ethdev.c | 18 ++++++----- lib/librte_ethdev/rte_ethdev.h | 9 +++++- lib/librte_ethdev/rte_ethdev_core.h | 4 +-- 65 files changed, 408 insertions(+), 176 deletions(-) -- 2.17.1