From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] l3fwd: fix incorrect size for destination port values
Date: Thu, 31 Mar 2016 22:44:34 +0200 [thread overview]
Message-ID: <1567958.mM9YQ1diUO@xps13> (raw)
In-Reply-To: <1459429639-30700-1-git-send-email-konstantin.ananyev@intel.com>
2016-03-31 14:07, Konstantin Ananyev:
> Fixes: dc81ebbacaeb ("lpm: extend IPv4 next hop field")
>
> Originally l3fwd used 16-bit value to store dest_port value.
> To accommodate 24-bit nexthop dest_port was increased to 32-bit,
> though some further packet processing code remained unchanged and
> still expects dest_port to be 16-bit.
> That is not correct and can cause l3fwd invalid behaviour or even
> process crash/hang on some input packet patterns.
> For the fix, I choose the simplest approach and restored dest_port
> as 16-bit value, plus necessary conversions from 32 to 16 bit values
> after lpm_lookupx4.
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks
prev parent reply other threads:[~2016-03-31 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 13:07 Konstantin Ananyev
2016-03-31 20:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567958.mM9YQ1diUO@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).