From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 5AA9D9616 for ; Thu, 31 Mar 2016 22:46:28 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id 127so147058493wmu.1 for ; Thu, 31 Mar 2016 13:46:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=k+jprZza8MQWq/sSpFCHKu0Dc723DhtHWKYsNOLbn5Q=; b=OkRqexPsz1ejb7T7MKK0qCsiBoS3+UXZ92shVl739h9OubiqLbllkwbyNs1ThiVq/f GgIZ+BW/lgzb+xOFZ8KlGQLaGhK1EynH2gehEzf7ZxI7TqsWw7HQRamKgpvFvLNnVwIr swe17DgMfHhyv8CfcuyEU4BJSJe5fhYI/72gtLuCd+0S0lyjZ5Q9FeP+PPKEad8pOzHJ 8OiyL//kWWOiFi9i51GbsAPI9IzM/E713XudOe7tzwRPkzmFzoz5C1PTUlBFJVV2ibG0 cEofxs5q7FRrbVVMcII7L7/jBnNPPuQiIpEC9+C89XUV7f3szsx3j+cnqnet75F/txdx 2kYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=k+jprZza8MQWq/sSpFCHKu0Dc723DhtHWKYsNOLbn5Q=; b=L8jA67Ok6qpdpe2SyP77Pm9Xc5zQq7pUnerFo2clF9hW1X70KjGqsyfPwgkQyKGRh5 +Nm+yIQxBeM47HAFLgGzRCDz8Ttkjt6F+zeliDZJdUFKFjvHgrJyd8hnm0pJQS/ciF1t 6fpnQTy7UA6lgEZDPHgUTa/LPv4PRRNodxUkWd8mJTD51SdVqS9QLlKWk6YzYBlrI2eb kMo3g/Z10k2lBmYOeMtJxfv8TN5gbaZ6uuIjqldKeNzukIPsrFDDq3N/IQprbWiiNFdJ zc8nb7gahTJ6ETIznGlBwcW7OtX3rEFmgnX4vC9GeHkCKyGGHDG69d210lpsWB/uGrWH gDvQ== X-Gm-Message-State: AD7BkJLdCmwsdchMQcIYk94K2PsxtdCPhodxoB2qnsk9wy29vv13MzfkCCgKmcgNreQgR243 X-Received: by 10.28.53.4 with SMTP id c4mr892157wma.34.1459457188238; Thu, 31 Mar 2016 13:46:28 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id 73sm26568944wmy.22.2016.03.31.13.46.27 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 31 Mar 2016 13:46:27 -0700 (PDT) From: Thomas Monjalon To: Konstantin Ananyev Cc: dev@dpdk.org Date: Thu, 31 Mar 2016 22:44:34 +0200 Message-ID: <1567958.mM9YQ1diUO@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1459429639-30700-1-git-send-email-konstantin.ananyev@intel.com> References: <1459429639-30700-1-git-send-email-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] l3fwd: fix incorrect size for destination port values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2016 20:46:28 -0000 2016-03-31 14:07, Konstantin Ananyev: > Fixes: dc81ebbacaeb ("lpm: extend IPv4 next hop field") > > Originally l3fwd used 16-bit value to store dest_port value. > To accommodate 24-bit nexthop dest_port was increased to 32-bit, > though some further packet processing code remained unchanged and > still expects dest_port to be 16-bit. > That is not correct and can cause l3fwd invalid behaviour or even > process crash/hang on some input packet patterns. > For the fix, I choose the simplest approach and restored dest_port > as 16-bit value, plus necessary conversions from 32 to 16 bit values > after lpm_lookupx4. > > Signed-off-by: Konstantin Ananyev Applied, thanks